Closed Bug 1596379 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20249 - taskcluster: ensure data.metadata.owner is a valid e-mail on push event (v5)

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20249 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20249
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

taskcluster: ensure data.metadata.owner is a valid e-mail on push event (v5)

  • The previous attempt (v4) worked and now we known the data that github is
    sending to taskcluster in the push event.

  • event.pusher.email is null, so it has to be null-checked before trying to
    test it to see if it contains an "@" inside.

  • this patch set as owner the event event.pusher.email if that seems to be
    a valid e-mail address, otherwise it sets web-platform-tests@users.noreply.github.com

Related issue: #20106

PR 20249 applied with additional changes from upstream: 8aeb44900921dce5401a91a2ede05dbbbb2d56f2, 689b968cd1f8848dc2c62928ffd1b20598be3537, c2910bf7a3f854c348c2f0c096543e7d60bc456f, beff32767b9e1234b09ab49fefcf565cf191f831, 3ee67ef03aeee31247ee1b5aca3e91ddef4fdfd8
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c68e0b28698
[wpt PR 20249] - taskcluster: ensure data.metadata.owner is a valid e-mail on push event (v5), a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/4c68e0b28698

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.