Closed
Bug 1596385
Opened 5 years ago
Closed 5 years ago
remove XUL [dir="reverse"] usage, support for which is getting removed in bug 1596296
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 72.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
3.87 KB,
patch
|
clokep
:
review+
pmorris
:
review+
|
Details | Diff | Splinter Review |
Remove XUL [dir="reverse"] usage, support for which is getting removed in bug 1596296.
https://searchfox.org/comm-central/search?q=dir%3D%22reverse%22&path=
|
Assignee | |
Comment 1•5 years ago
|
||
For chat, I think we should just remove the dir=reverse, so that the checkbox is before the label like the normal way. (It's like that on nightly already now since m-c changes landed.)
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9109237 -
Flags: review?(paul)
Attachment #9109237 -
Flags: review?(clokep)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9109237 [details] [diff] [review] bug1596385_xul_dir_reverse.patch Looks good for the chat part.
Attachment #9109237 -
Flags: review?(clokep) → review+
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9109237 [details] [diff] [review] bug1596385_xul_dir_reverse.patch Review of attachment 9109237 [details] [diff] [review]: ----------------------------------------------------------------- Calendar changes LGTM. No adverse effects observed when testing the calendar event attendees dialog.
Attachment #9109237 -
Flags: review?(paul) → review+
|
||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/12ab920cd2e7
remove XUL [dir="reverse"] usage whose support was removed in bug 1596296. r=clokep,pmorris
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 72.0
You need to log in
before you can comment on or make changes to this bug.
Description
•