1596562 - Add ParamTraits specializations for mozilla::Vector and std::vector

Status: RESOLVED FIXED

(Core :: IPC, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

While the need for adding mozilla::Vector is self-evident, we also need std::vector so that we can send some pre-existing telemetry data structures that use it.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

There's already a specialization for std::vector in dom/media/webrtc/WebrtcIPCTraits.h that can (and should) be moved somewhere more central.

Also, note that there's ParamTraits and IPDLParamTraits (which includes an actor parameter for things that need to send out-of-band messages or otherwise access the channel), but I don't know if any types that are IPDLParamTraits-only would be the element type of a vector.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Yes, my patch creates a centralized std::vector specialization and changes webrtc to use it.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1596562: Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,jesup

While the need for adding mozilla::Vector is self-evident, we also need
std::vector so that we can send some pre-existing telemetry data structures
that use it.

The new implementations are basically modified from the nsTArray
specializations. Note that the mozilla::Vector specialization does support
any type of allocator, so we still check for OOM failures in that case.

This patch also removes the specialization for std::vector that lives in
WebRTC in favour of the centralized implementation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/855640e1c096
Add ParamTraits specializations for mozilla::Vector and std::vector; r=froydnj,bwc

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/855640e1c096