Closed Bug 1596564 Opened 11 months ago Closed 10 months ago

Add ParamTraits for CombinedStacks and ProcessedStack

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file)

We're going to need to be able to send those over IPC.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c906a25fce8c
ParamTraits for CombinedStacks and ProcessedStack; r=janerik

Backed out changeset c906a25fce8c (Bug 1596564) for build bustage at builds/worker/workspace/build/src/obj-firefox/dist/include/ipc/IPCMessageUtils.h:10:10.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=276995504&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c906a25fce8cd87b1fa529833329469f4bd7cfb9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276995504&repo=autoland&lineNumber=35393

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=276998566&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=5b05b982134618f31c0f3b3a21ad33dbb95bec99

[task 2019-11-19T16:18:40.555Z] 16:18:40     INFO -  /builds/worker/fetches/clang/bin/clang++ -std=gnu++14 -o Unified_cpp_webrequest0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/extensions/webrequest -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/extensions/webrequest -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/netwerk/protocol/http -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_webrequest0.o.pp   Unified_cpp_webrequest0.cpp
[task 2019-11-19T16:18:40.555Z] 16:18:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/extensions/webrequest'
[task 2019-11-19T16:18:40.575Z] 16:18:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes/tests'
[task 2019-11-19T16:18:40.575Z] 16:18:40     INFO -  mkdir -p '.deps/'
[task 2019-11-19T16:18:40.575Z] 16:18:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes/tests'
[task 2019-11-19T16:18:40.591Z] 16:18:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes/tests'
[task 2019-11-19T16:18:40.591Z] 16:18:40     INFO -  toolkit/components/ctypes/tests/Unified_cpp_ctypes_tests0.o
[task 2019-11-19T16:18:40.592Z] 16:18:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes/tests'
[task 2019-11-19T16:18:40.653Z] 16:18:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry/tests/gtest'
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -  /builds/worker/fetches/clang/bin/clang++ -std=gnu++14 -o Unified_cpp_tests_gtest0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/telemetry/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry/tests/gtest -I/builds/worker/workspace/build/src/toolkit/components/telemetry -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_tests_gtest0.o.pp   Unified_cpp_tests_gtest0.cpp
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -  In file included from Unified_cpp_tests_gtest0.cpp:20:
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -  In file included from /builds/worker/workspace/build/src/toolkit/components/telemetry/tests/gtest/TestCombinedStacks.cpp:5:
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -  In file included from /builds/worker/workspace/build/src/toolkit/components/telemetry/other/CombinedStacks.h:11:
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/ipc/IPCMessageUtils.h:10:10: fatal error: 'base/process_util.h' file not found
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -  #include "base/process_util.h"
[task 2019-11-19T16:18:40.654Z] 16:18:40     INFO -           ^~~~~~~~~~~~~~~~~~~~~
[task 2019-11-19T16:18:40.655Z] 16:18:40     INFO -  1 error generated.
[task 2019-11-19T16:18:40.655Z] 16:18:40     INFO -  /builds/worker/workspace/build/src/config/rules.mk:787: recipe for target 'Unified_cpp_tests_gtest0.o' failed
[task 2019-11-19T16:18:40.655Z] 16:18:40    ERROR -  make[4]: *** [Unified_cpp_tests_gtest0.o] Error 1
[task 2019-11-19T16:18:40.655Z] 16:18:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry/tests/gtest'
[task 2019-11-19T16:18:40.655Z] 16:18:40     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/components/telemetry/tests/gtest/target-objects' failed
[task 2019-11-19T16:18:40.655Z] 16:18:40    ERROR -  make[3]: *** [toolkit/components/telemetry/tests/gtest/target-objects] Error 2
[task 2019-11-19T16:18:40.655Z] 16:18:40     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2019-11-19T16:18:40.658Z] 16:18:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier/tests/gtest'
[task 2019-11-19T16:18:40.658Z] 16:18:40     INFO -  toolkit/components/url-classifier/tests/gtest/Unified_cpp_tests_gtest1.o
[task 2019-11-19T16:18:40.658Z] 16:18:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier/tests/gtest'
[task 2019-11-19T16:18:40.855Z] 16:18:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/xulstore/tests/gtest'
[task 2019-11-19T16:18:40.855Z] 16:18:40     INFO -  /builds/worker/fetches/clang/bin/clang++ -std=gnu++14 -o Unified_cpp_tests_gtest0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/xulstore/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/xulstore/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_tests_gtest0.o.pp   Unified_cpp_tests_gtest0.cpp
[task 2019-11-19T16:18:40.855Z] 16:18:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/xulstore/tests/gtest'
[task 2019-11-19T16:18:40.856Z] 16:18:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier'
[task 2019-11-19T16:18:40.856Z] 16:18:40     INFO -  toolkit/components/url-classifier/Unified_cpp_url-classifier0.o
Flags: needinfo?(aklotz)
Flags: needinfo?(aklotz)
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8ffac24c3db
ParamTraits for CombinedStacks and ProcessedStack; r=janerik
Flags: needinfo?(aklotz)
Depends on: 1598098
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4768bc0cdd40
ParamTraits for CombinedStacks and ProcessedStack; r=janerik
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.