1596601 - Add place-holder for Page.setInterceptFileChooserDialog

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

This method affects many Puppeteer unit tests and gutenberg tests, since it's involved in creating a Page class.

"When file chooser interception is enabled, native file chooser dialog is not shown. Instead, a protocol event Page.fileChooserOpened is emitted."

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I asked Olli on IRC and he pointed me to:

•smaug> whimboo: https://searchfox.org/mozilla-central/source/testing/specialpowers/content/MockFilePicker.jsm#42 is used by several tests https://searchfox.org/mozilla-central/search?q=mockfile&path=

It doesn't look too hard to get implemented. Also we would only need a bare minimum of what SpecialPowers implements.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While this method affects a lot of tests it's not a blocker for the alpha release. Reason is that there is a fallback:
https://github.com/puppeteer/puppeteer/blob/master/lib/Page.js#L140-L142

It also means that this failure doesn't cause the hang for most of the Puppeteer unit tests.

Comment 3

[Andreas Tolfsen ❲:ato❳]

There doesn’t appear to be a fallback, but it sets the internal state _fileChooserInterceptionIsDisabled.
I looked, but couldn’t find this was used for anything.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Note that this API is marked as experimental in Puppeteer. As such I think it should be enough to just add a place-holder for now. Given that it sets the internal state (as mentioned above) we should get around from those many failures in Puppeteer unit tests.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1596601 - [remote] Add place-holder for Page.setInterceptFileChooserDialog.

This feature is experimental and not required to get implemented
on our end as of now. As such adding a place-holder will be enough.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=7745788be264d8b08163badb6f9b289fd5809452

With this push some more Puppeteer tests crash. I will have to also mark those as skipped.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1596601 - [remote] Skip some more crashing Puppeteer unit tests.

Depends on D59006

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d212635f9463
[remote] Add place-holder for Page.setInterceptFileChooserDialog. r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/267643528022
[remote] Skip some more crashing Puppeteer unit tests. r=remote-protocol-reviewers,ato

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d212635f9463
https://hg.mozilla.org/mozilla-central/rev/267643528022