Closed Bug 1596642 Opened 1 year ago Closed 1 year ago

cargo warning when building cert_storage: dependency (rkv) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed.

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: heycam, Assigned: vporof)

References

(Regression)

Details

Attachments

(1 file)

When I build I get a few warnings like:

warning: /z/moz/k/security/manager/ssl/cert_storage/Cargo.toml: dependency (rkv) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed. This will be considered an error in future versions

I guess the tag = "0.11.0" should be dropped.

Flags: needinfo?(vporof)

I'd say both branch and tag should be removed, and rev used instead.

Yes, you're right -- branch will change.

Tag can indeed change the revision it's referring to, and although we don't intend to do something like that, it's a good idea to use rev instead.

There's precedent here with something I fixed just a few days ago, see https://phabricator.services.mozilla.com/D52316

Flags: needinfo?(vporof)
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Pushed by vporof@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b81c1543943d
Use `rev` instead of both `branch` and `tag` for specifying rkv dependency version, r=heycam
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.