1596642 - cargo warning when building cert_storage: dependency (rkv) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed.

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Cameron McCormack (:heycam)]

When I build I get a few warnings like:

warning: /z/moz/k/security/manager/ssl/cert_storage/Cargo.toml: dependency (rkv) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed. This will be considered an error in future versions

I guess the tag = "0.11.0" should be dropped.

Comment 1

[Mike Hommey [:glandium]]

I'd say both branch and tag should be removed, and rev used instead.

Comment 2

[Cameron McCormack (:heycam)]

Yes, you're right -- branch will change.

Comment 3

[Victor Porof [:vporof][:vp]]

Tag can indeed change the revision it's referring to, and although we don't intend to do something like that, it's a good idea to use rev instead.

There's precedent here with something I fixed just a few days ago, see https://phabricator.services.mozilla.com/D52316

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1596642 - Use `rev` instead of both `branch` and `tag` for specifying rkv dependency version, r=heycam

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b81c1543943d
Use `rev` instead of both `branch` and `tag` for specifying rkv dependency version, r=heycam

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b81c1543943d