1596662 - Addresses and Credit-Cards may start syncing without it being offered by CWTS

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

This is a bit of an edge-case, but:

• Have some Nightly profile where you flipped services.sync.engine.addresses.available to true, chose to sync the "addresses" engine, and recently synced.

• Have a new Nightly profile, or a profile you just disconnected from sync, and where you are signed in to FxA.

• Connect sync on this profile. Note how "addresses" is not offered in the CWTS dialog used to enable sync.

• Wait for the sync to complete. Note how "addresses" is now enabled.

Not a huge deal because you did previously accept syncing this data. It's quite spooky though :) I think this is worth addressing because the fix is simple, but I don't think I'll bother requesting uplift.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1596662 - make the addresses and credit-cards engines available if we find they are enabled. r?eoger

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ea9b3f1de72
make the addresses and credit-cards engines available if we find they are enabled. r=eoger

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5ea9b3f1de72