Closed Bug 1596666 Opened 5 months ago Closed 5 months ago

Port bug 1578534 - Change nsIX509CertDB.constructX509 to take Array<uint8_t>

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file, 1 obsolete file)

This will break the build when it merges from autoland. If my hacked-up attempt to fix it finishes compiling, I'll post it here.

Attached patch 1596666-port-bug1578534.diff (obsolete) — Splinter Review
Attachment #9108935 - Flags: review?(jorgk)
Comment on attachment 9108935 [details] [diff] [review]
1596666-port-bug1578534.diff

Thanks, this looks pretty good as port of
https://hg.mozilla.org/integration/autoland/rev/4eb85afc10db#l3.12
I'll s/clientCertBytes/certBytes/, I don't know how the client slipped in here.
Attachment #9108935 - Flags: review?(jorgk) → review+

Great bug number, BTW ;-)

Attachment #9108935 - Attachment is obsolete: true
Attachment #9108956 - Flags: review+
Assignee: nobody → geoff
Status: NEW → ASSIGNED

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/54ccc35a7b0b
Port bug 1578534: Change nsIX509CertDB.constructX509 to take Array<uint8_t>. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.