1596741 - Emit warning to console when rejecting to set cookie (from cross-site/foreign domain)

Reporter

Description

•

5 years ago

It would be nice if the browser would emit a warning to the console when it rejects a cookie: Either rejects a cookie using the document.cookie setter, or rejects a cookie from a Set-Cookie in a response header of a fetch() call.

It would really help with debugging.

https://discourse.mozilla.org/t/fetch-will-not-accept-cross-site-foreign-cookies/48616

Thank you

Dragana Damjanovic [:dragana]

Comment 1

•

5 years ago

Honza, can you take a look or give it to someone else from the cookie team?

Flags: needinfo?(honzab.moz)

Honza Bambas (:mayhemer)

Assignee

Updated

•

5 years ago

Flags: needinfo?(honzab.moz)

Priority: -- → P2

Whiteboard: [necko-triaged]

Honza Bambas (:mayhemer)

Assignee

Comment 2

•

5 years ago

Ehsan, do you know where in the code this should happen? I don't mean you have to write a patch but having a pointer would speed this up. Thanks.

Andrea Marchesini [:baku]

Comment 3

•

4 years ago

document.cookie = "foo" triggers this check:
https://searchfox.org/mozilla-central/rev/0439db3a39faddb90197a87cc184c57dcbf0a770/netwerk/cookie/CookieServiceChild.cpp#530-533

networking operations are handled here:
https://searchfox.org/mozilla-central/rev/0439db3a39faddb90197a87cc184c57dcbf0a770/netwerk/cookie/nsCookieService.cpp#2207

But maybe we implement the notification into CheckPrefs() too, but in this case, we need to do it only for writing operations.

Flags: needinfo?(honzab.moz)

Honza Bambas (:mayhemer)

Assignee

Updated

•

4 years ago

Assignee: nobody → honzab.moz

Flags: needinfo?(honzab.moz)

Honza Bambas (:mayhemer)

Assignee

Comment 4

•

4 years ago

Thanks, :baku!

Andrea Marchesini [:baku]

Comment 5

•

4 years ago

I recently introduce a LogMessageToConsole() method. This should make the fix easier.

Honza Bambas (:mayhemer)

Assignee

Comment 6

•

4 years ago

baku, I recently found very useful to look for the cookie logs in MOZ_LOG for rejection reason. When looking at the proposed places from comment 3, I'm not sure it will be sufficient when compared to where all we use COOKIE_LOGFAILURE: https://searchfox.org/mozilla-central/search?q=symbol:M_c1a2d2c63b08f518&redirect=false.

Should I follow comment 3 only or all places we log?

Flags: needinfo?(amarchesini)

Andrea Marchesini [:baku]

Comment 7

•

4 years ago

If we care about the samesite attribute and the cross-origin check, those are the only 2 places we care. Any additional log is welcome but with different error messages.

I went through all the COOKIE_LOGFAILURE and here is the list of what I think we should cover. Maybe in separate bugs (one per type?).

I would not write console messages for "internal" failures such as:

baseDomain failure: https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/netwerk/cookie/CookieService.cpp#526
getAsciiHost/getFileURI failures: https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/netwerk/cookie/CookieService.cpp#857
sameSite cross-origin check: https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/netwerk/cookie/CookieService.cpp#1121
invalid scheme: https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/netwerk/cookie/CookieService.cpp#1498
principal failures: https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/netwerk/cookie/CookieService.cpp#1508

Nice to have are:

We already have console log messages for:

Flags: needinfo?(amarchesini)

Honza Bambas (:mayhemer)

Assignee

Comment 8

•

4 years ago

Attached file Bug 1596741 - Emit warning to console when rejecting to set cookie, r=baku — Details

Pulsebot

Comment 9

•

4 years ago

Pushed by honzab.moz@firemni.cz:
https://hg.mozilla.org/integration/autoland/rev/72e7c3e8393e
Emit warning to console when rejecting to set cookie, r=baku

Natalia Csoregi [:nataliaCs]

Comment 10

•

4 years ago

Backed out as requested: https://hg.mozilla.org/integration/autoland/rev/2afec1dfd8fc6bf65f32d4efeffd7596254c03b5

Honza Bambas (:mayhemer)

Assignee

Updated

•

4 years ago

Flags: needinfo?(honzab.moz)

Honza Bambas (:mayhemer)

Assignee

Comment 11

•

4 years ago

Patch updated.

Flags: needinfo?(honzab.moz)

Pulsebot

Comment 12

•

4 years ago

Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0cc074b94631
Emit warning to console when rejecting to set cookie, r=baku,flod

Bogdan Tara[:bogdan_tara | bogdant]

Comment 13

•

4 years ago

Backed out changeset 0cc074b94631 (bug 1596741) for assertion failure on CookieLogging.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=marionette&fromchange=e1c5c97858c851fd5e5f1a4508f6271156b99df8&tochange=6575e34851ec454177d04caadf28574a3f1ac99f&selectedTaskRun=CWtMAtR3SBGbNrPPXZqyfA.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/6575e34851ec454177d04caadf28574a3f1ac99f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310255228&repo=autoland&lineNumber=31828

[task 2020-07-18T06:42:54.028Z] 06:42:54     INFO -  TEST-START | testing/marionette/harness/marionette_harness/tests/unit/test_cookies.py CookieTest.test_adding_a_cookie_that_expired_in_the_past
[task 2020-07-18T06:42:54.907Z] 06:42:54     INFO -  1595054574887	Marionette	DEBUG	Closed connection 123
[task 2020-07-18T06:42:54.907Z] 06:42:54     INFO -  1595054574888	Marionette	DEBUG	Accepted connection 124 from 127.0.0.1:50665
[task 2020-07-18T06:42:54.922Z] 06:42:54     INFO -  1595054574895	Marionette	DEBUG	124 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2020-07-18T06:42:54.922Z] 06:42:54     INFO -  1595054574908	Marionette	TRACE	[139] Frame script loaded
[task 2020-07-18T06:42:54.922Z] 06:42:54     INFO -  1595054574909	Marionette	TRACE	[139] Frame script registered
[task 2020-07-18T06:42:54.922Z] 06:42:54     INFO -  1595054574902	Marionette	DEBUG	124 <- [1,1,null,{"sessionId":"e33db7df-21dc-4280-897b-7eceb4b978c0","capabilities":{"browserName":"firefox","browserVersion":"80.0a ... p\\tmpgo2ini.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574952	Marionette	DEBUG	124 -> [0,2,"WebDriver:SetTimeouts",{"script":30000}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574953	Marionette	DEBUG	124 <- [1,2,null,{"value":null}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574954	Marionette	DEBUG	124 -> [0,3,"WebDriver:SetTimeouts",{"pageLoad":300000}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574954	Marionette	DEBUG	124 <- [1,3,null,{"value":null}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574955	Marionette	DEBUG	124 -> [0,4,"WebDriver:SetTimeouts",{"implicit":0}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574955	Marionette	DEBUG	124 <- [1,4,null,{"value":null}]
[task 2020-07-18T06:42:54.977Z] 06:42:54     INFO -  1595054574957	Marionette	DEBUG	124 -> [0,5,"WebDriver:Navigate",{"url":"http://127.0.0.1:49304/test.html"}]
[task 2020-07-18T06:42:54.984Z] 06:42:54     INFO -  1595054574972	Marionette	TRACE	[139] Received DOM event beforeunload for http://127.0.0.1:49304/test.html
[task 2020-07-18T06:42:55.003Z] 06:42:55     INFO -  1595054574994	Marionette	TRACE	[139] Received DOM event pagehide for http://127.0.0.1:49304/test.html
[task 2020-07-18T06:42:55.038Z] 06:42:55     INFO -  1595054575021	Marionette	TRACE	[139] Received DOM event DOMContentLoaded for http://127.0.0.1:49304/test.html
[task 2020-07-18T06:42:55.053Z] 06:42:55     INFO -  1595054575031	Marionette	TRACE	[139] Received DOM event pageshow for http://127.0.0.1:49304/test.html
[task 2020-07-18T06:42:55.108Z] 06:42:55     INFO -  1595054575077	Marionette	DEBUG	124 <- [1,5,null,{"value":null}]
[task 2020-07-18T06:42:55.123Z] 06:42:55     INFO -  1595054575097	Marionette	DEBUG	124 -> [0,6,"WebDriver:AddCookie",{"cookie":{"path":"/","expiry":1594968175,"name":"foo","value":"bar","secure":false}}]
[task 2020-07-18T06:42:55.123Z] 06:42:55     INFO -  Assertion failure: aURI, at /builds/worker/checkouts/gecko/netwerk/cookie/CookieLogging.cpp:166
[task 2020-07-18T06:42:55.278Z] 06:42:55     INFO -  #01: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x325f39]
[task 2020-07-18T06:42:55.278Z] 06:42:55     INFO -  #02: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x329170]
[task 2020-07-18T06:42:55.278Z] 06:42:55     INFO -  #03: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x328c79]
[task 2020-07-18T06:42:55.278Z] 06:42:55     INFO -  #04: v8::internal::RegExpMacroAssembler::LoadCurrentCharacter[Z:\task_1595053929\build\application\firefox\xul.dll +0x7a04027]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #05: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0xf95616]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #06: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0xf953ea]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #07: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0xf96a76]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #08: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d44c0]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #09: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d3ea2]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #10: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5435]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #11: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55c9a00]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #12: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55c0b41]
[task 2020-07-18T06:42:55.279Z] 06:42:55     INFO -  #13: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d3e56]
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #14: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5435]
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #15: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5671]
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #16: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x5917ebb]
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #17: v8::internal::RegExpBytecodeGenerator::Copy[Z:\task_1595053929\build\application\firefox\xul.dll +0x741d64d]
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #18: ??? (???:???)
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #19: ??? (???:???)
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #20: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x6463da3]
[task 2020-07-18T06:42:55.280Z] 06:42:55     INFO -  #21: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55c0b05]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #22: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d3e56]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #23: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5435]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #24: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5671]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #25: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x5917ebb]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #26: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x572ae11]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #27: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x572aac3]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #28: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x57fb592]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #29: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d44c0]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #30: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d3ea2]
[task 2020-07-18T06:42:55.281Z] 06:42:55     INFO -  #31: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5435]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #32: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x55d5671]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #33: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x56a8b03]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #34: VR_RuntimePath[Z:\task_1595053929\build\application\firefox\xul.dll +0x1fc3e26]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #35: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x77d22]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #36: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x77055]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #37: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x683c9]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #38: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x68d16]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #39: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0xf5f65f]
[task 2020-07-18T06:42:55.282Z] 06:42:55     INFO -  #40: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x16ba29]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #41: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x170c78]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #42: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x8ed09a]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #43: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x899151]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #44: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x899063]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #45: Ordinal0[Z:\task_1595053929\build\application\firefox\xul.dll +0x898f27]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #46: soundtouch::SoundTouch::operator=[Z:\task_1595053929\build\application\firefox\xul.dll +0x3bcb615]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #47: soundtouch::SoundTouch::operator=[Z:\task_1595053929\build\application\firefox\xul.dll +0x3c5a302]
[task 2020-07-18T06:42:55.283Z] 06:42:55     INFO -  #48: workerlz4_maxCompressedSize[Z:\task_1595053929\build\application\firefox\xul.dll +0x536f42c]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #49: workerlz4_maxCompressedSize[Z:\task_1595053929\build\application\firefox\xul.dll +0x5488156]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #50: workerlz4_maxCompressedSize[Z:\task_1595053929\build\application\firefox\xul.dll +0x5489f1a]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #51: workerlz4_maxCompressedSize[Z:\task_1595053929\build\application\firefox\xul.dll +0x548a697]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #52: XRE_GetBootstrap[Z:\task_1595053929\build\application\firefox\xul.dll +0x549ffd1]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #53: Ordinal0[Z:\task_1595053929\build\application\firefox\firefox.exe +0x14fd]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #54: Ordinal0[Z:\task_1595053929\build\application\firefox\firefox.exe +0x11cf]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #55: TargetNtUnmapViewOfSection[Z:\task_1595053929\build\application\firefox\firefox.exe +0x85579]
[task 2020-07-18T06:42:55.284Z] 06:42:55     INFO -  #56: BaseThreadInitThunk[C:\windows\system32\kernel32.dll +0x4ef3c]
[task 2020-07-18T06:42:55.285Z] 06:42:55     INFO -  #57: RtlInitializeExceptionChain[C:\windows\SYSTEM32\ntdll.dll +0x63618]
[task 2020-07-18T06:42:55.285Z] 06:42:55     INFO -  #58: RtlInitializeExceptionChain[C:\windows\SYSTEM32\ntdll.dll +0x635eb]
[task 2020-07-18T06:42:55.400Z] 06:42:55     INFO -  Exiting due to channel error.
[task 2020-07-18T06:42:55.460Z] 06:42:55     INFO -  mozcrash Copy/paste: Z:/task_1595053929/fetches\minidump_stackwalk\minidump_stackwalk.exe c:\users\task_1595053929\appdata\local\temp\tmpgo2ini.mozrunner\minidumps\8b5934a0-a567-4981-927c-bfa1280d43ce.dmp Z:\task_1595053929\build\symbols
[task 2020-07-18T06:43:15.075Z] 06:43:15     INFO -  mozcrash Saved minidump as Z:\task_1595053929\build\blobber_upload_dir\8b5934a0-a567-4981-927c-bfa1280d43ce.dmp
[task 2020-07-18T06:43:15.075Z] 06:43:15     INFO -  mozcrash Saved app info as Z:\task_1595053929\build\blobber_upload_dir\8b5934a0-a567-4981-927c-bfa1280d43ce.extra
[task 2020-07-18T06:43:15.082Z] 06:43:15    ERROR -  PROCESS-CRASH | testing/marionette/harness/marionette_harness/tests/unit/test_cookies.py CookieTest.test_adding_a_cookie_that_expired_in_the_past | application crashed [@ static mozilla::net::CookieLogging::LogMessageToConsole(nsIConsoleReportCollector*, nsIURI*, unsigned int, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTArray<nsTString<char16_t> > const&)]
[task 2020-07-18T06:43:15.083Z] 06:43:15     INFO -  Mozilla crash reason: MOZ_ASSERT(aURI)
[task 2020-07-18T06:43:15.083Z] 06:43:15     INFO -  Crash dump filename: c:\users\task_1595053929\appdata\local\temp\tmpgo2ini.mozrunner\minidumps\8b5934a0-a567-4981-927c-bfa1280d43ce.dmp
[task 2020-07-18T06:43:15.084Z] 06:43:15     INFO -  Operating system: Windows NT
[task 2020-07-18T06:43:15.084Z] 06:43:15     INFO -                    6.1.7601 Service Pack 1
[task 2020-07-18T06:43:15.084Z] 06:43:15     INFO -  CPU: x86
[task 2020-07-18T06:43:15.085Z] 06:43:15     INFO -       GenuineIntel family 6 model 63 stepping 2
[task 2020-07-18T06:43:15.085Z] 06:43:15     INFO -       8 CPUs
[task 2020-07-18T06:43:15.086Z] 06:43:15     INFO -  GPU: UNKNOWN
[task 2020-07-18T06:43:15.086Z] 06:43:15     INFO -  Crash reason:  EXCEPTION_BREAKPOINT
[task 2020-07-18T06:43:15.086Z] 06:43:15     INFO -  Crash address: 0x53a05a8e
[task 2020-07-18T06:43:15.087Z] 06:43:15     INFO -  Process uptime: 61 seconds
[task 2020-07-18T06:43:15.087Z] 06:43:15     INFO -  Thread 0 (crashed)
[task 2020-07-18T06:43:15.088Z] 06:43:15     INFO -   0  xul.dll!static mozilla::net::CookieLogging::LogMessageToConsole(nsIConsoleReportCollector*, nsIURI*, unsigned int, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTArray<nsTString<char16_t> > const&) [CookieLogging.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 166 + 0x0]
[task 2020-07-18T06:43:15.088Z] 06:43:15     INFO -      eip = 0x53a05a8e   esp = 0x001bda90   ebp = 0x001bdb00   ebx = 0x00000000
[task 2020-07-18T06:43:15.088Z] 06:43:15     INFO -      esi = 0x001bdbec   edi = 0x001bdbe0   eax = 0x6b756994   ecx = 0x000000a6
[task 2020-07-18T06:43:15.089Z] 06:43:15     INFO -      edx = 0x00000049   efl = 0x00000216
[task 2020-07-18T06:43:15.089Z] 06:43:15     INFO -      Found by: given as instruction pointer in context
[task 2020-07-18T06:43:15.090Z] 06:43:15     INFO -   1  xul.dll!mozilla::net::CookieStorage::AddCookie(nsIConsoleReportCollector*, nsTSubstring<char> const&, mozilla::OriginAttributes const&, mozilla::net::Cookie*, long long, nsIURI*, nsTSubstring<char> const&, bool) [CookieStorage.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 546 + 0x12]
[task 2020-07-18T06:43:15.090Z] 06:43:15     INFO -      eip = 0x53a15f39   esp = 0x001bdb08   ebp = 0x001bdc14   ebx = 0x00000000
[task 2020-07-18T06:43:15.090Z] 06:43:15     INFO -      esi = 0x001bdbec   edi = 0x001bdbe0
[task 2020-07-18T06:43:15.091Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.091Z] 06:43:15     INFO -   2  xul.dll!mozilla::net::CookieService::AddNative(nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, bool, bool, bool, long long, mozilla::OriginAttributes*, int, nsICookie::schemeType) [CookieService.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 772 + 0x25]
[task 2020-07-18T06:43:15.091Z] 06:43:15     INFO -      eip = 0x53a19170   esp = 0x001bdc1c   ebp = 0x001bdde4   ebx = 0x001bde20
[task 2020-07-18T06:43:15.091Z] 06:43:15     INFO -      esi = 0x191fe920   edi = 0x0fe36900
[task 2020-07-18T06:43:15.092Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.092Z] 06:43:15     INFO -   3  xul.dll!mozilla::net::CookieService::Add(nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, bool, bool, bool, long long, JS::Handle<JS::Value>, int, nsICookie::schemeType, JSContext*) [CookieService.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 730 + 0x38]
[task 2020-07-18T06:43:15.092Z] 06:43:15     INFO -      eip = 0x53a18c79   esp = 0x001bddec   ebp = 0x001bde6c   ebx = 0x1bfc02c8
[task 2020-07-18T06:43:15.093Z] 06:43:15     INFO -      esi = 0x00000001   edi = 0x001bde20
[task 2020-07-18T06:43:15.093Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.094Z] 06:43:15     INFO -   4  xul.dll!NS_InvokeByIndex + 0x27
[task 2020-07-18T06:43:15.094Z] 06:43:15     INFO -      eip = 0x5b0f4027   esp = 0x001bde74   ebp = 0x001bded8   ebx = 0x0000000a
[task 2020-07-18T06:43:15.094Z] 06:43:15     INFO -      esi = 0x001bdf18   edi = 0x0000000a
[task 2020-07-18T06:43:15.095Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.095Z] 06:43:15     INFO -   5  xul.dll!CallMethodHelper::Call() [XPCWrappedNative.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 1174 + 0x16]
[task 2020-07-18T06:43:15.096Z] 06:43:15     INFO -      eip = 0x54685616   esp = 0x001bdee0   ebp = 0x001bdf00
[task 2020-07-18T06:43:15.096Z] 06:43:15     INFO -      Found by: previous frame's frame pointer
[task 2020-07-18T06:43:15.096Z] 06:43:15     INFO -   6  xul.dll!static XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) [XPCWrappedNative.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 1140 + 0x5]
[task 2020-07-18T06:43:15.097Z] 06:43:15     INFO -      eip = 0x546853ea   esp = 0x001bdf08   ebp = 0x001be030   ebx = 0x001bdf18
[task 2020-07-18T06:43:15.097Z] 06:43:15     INFO -      esi = 0x001bdf18   edi = 0x001bdf08
[task 2020-07-18T06:43:15.098Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.098Z] 06:43:15     INFO -   7  xul.dll!XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) [XPCWrappedNativeJSOps.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 946 + 0x9]
[task 2020-07-18T06:43:15.099Z] 06:43:15     INFO -      eip = 0x54686a76   esp = 0x001be038   ebp = 0x001be0cc   ebx = 0x001be040
[task 2020-07-18T06:43:15.099Z] 06:43:15     INFO -      esi = 0x173e9e04   edi = 0x173e9dc0
[task 2020-07-18T06:43:15.100Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.100Z] 06:43:15     INFO -   8  xul.dll!CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 484 + 0x7]
[task 2020-07-18T06:43:15.100Z] 06:43:15     INFO -      eip = 0x58cc44c0   esp = 0x001be0d4   ebp = 0x001be138   ebx = 0x0c214000
[task 2020-07-18T06:43:15.101Z] 06:43:15     INFO -      esi = 0x54686750   edi = 0x001be2f0
[task 2020-07-18T06:43:15.101Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.102Z] 06:43:15     INFO -   9  xul.dll!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 576 + 0xb]
[task 2020-07-18T06:43:15.102Z] 06:43:15     INFO -      eip = 0x58cc3ea2   esp = 0x001be140   ebp = 0x001be1a8   ebx = 0x00000000
[task 2020-07-18T06:43:15.103Z] 06:43:15     INFO -      esi = 0x001be2f0   edi = 0x54686750
[task 2020-07-18T06:43:15.103Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.103Z] 06:43:15     INFO -  10  xul.dll!InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 639 + 0xc]
[task 2020-07-18T06:43:15.104Z] 06:43:15     INFO -      eip = 0x58cc5435   esp = 0x001be1b0   ebp = 0x001be1e4   ebx = 0x001be1c8
[task 2020-07-18T06:43:15.104Z] 06:43:15     INFO -      esi = 0x224241a8   edi = 0x001be2f0
[task 2020-07-18T06:43:15.104Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.105Z] 06:43:15     INFO -  11  xul.dll!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 3332 + 0x15]
[task 2020-07-18T06:43:15.105Z] 06:43:15     INFO -      eip = 0x58cb9a00   esp = 0x001be1ec   ebp = 0x001be518   ebx = 0x0000000b
[task 2020-07-18T06:43:15.106Z] 06:43:15     INFO -      esi = 0xffffff8c   edi = 0x188c7550
[task 2020-07-18T06:43:15.107Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.107Z] 06:43:15     INFO -  12  xul.dll!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 456 + 0x9]
[task 2020-07-18T06:43:15.108Z] 06:43:15     INFO -      eip = 0x58cb0b41   esp = 0x001be520   ebp = 0x001be540   ebx = 0x0ce03bd1
[task 2020-07-18T06:43:15.108Z] 06:43:15     INFO -      esi = 0x0c214000   edi = 0x001be560
[task 2020-07-18T06:43:15.108Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.109Z] 06:43:15     INFO -  13  xul.dll!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 611 + 0x9]
[task 2020-07-18T06:43:15.109Z] 06:43:15     INFO -      eip = 0x58cc3e56   esp = 0x001be548   ebp = 0x001be5a8   ebx = 0x001be560
[task 2020-07-18T06:43:15.110Z] 06:43:15     INFO -      esi = 0x001be690   edi = 0x00000000
[task 2020-07-18T06:43:15.110Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.111Z] 06:43:15     INFO -  14  xul.dll!InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 639 + 0xc]
[task 2020-07-18T06:43:15.111Z] 06:43:15     INFO -      eip = 0x58cc5435   esp = 0x001be5b0   ebp = 0x001be5e8   ebx = 0x0c214000
[task 2020-07-18T06:43:15.112Z] 06:43:15     INFO -      esi = 0x001be6c0   edi = 0x001be690
[task 2020-07-18T06:43:15.112Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.113Z] 06:43:15     INFO -  15  xul.dll!js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 656 + 0x6]
[task 2020-07-18T06:43:15.113Z] 06:43:15     INFO -      eip = 0x58cc5671   esp = 0x001be5f0   ebp = 0x001be600   ebx = 0x0c214000
[task 2020-07-18T06:43:15.114Z] 06:43:15     INFO -      esi = 0x001be690   edi = 0x0c248370
[task 2020-07-18T06:43:15.114Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.115Z] 06:43:15     INFO -  16  xul.dll!js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName *>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [SelfHosting.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 1688 + 0x18]
[task 2020-07-18T06:43:15.116Z] 06:43:15     INFO -      eip = 0x59007ebb   esp = 0x001be608   ebp = 0x001be654   ebx = 0x0c214000
[task 2020-07-18T06:43:15.116Z] 06:43:15     INFO -      esi = 0x0c23d048
[task 2020-07-18T06:43:15.116Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.117Z] 06:43:15     INFO -  17  xul.dll!js::jit::InterpretResume(JSContext*, JS::Handle<JSObject *>, JS::Value*, JS::MutableHandle<JS::Value>) [VMFunctions.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 999 + 0xa]
[task 2020-07-18T06:43:15.117Z] 06:43:15     INFO -      eip = 0x5ab0d64d   esp = 0x001be65c   ebp = 0x001be6f0   ebx = 0x0c214000
[task 2020-07-18T06:43:15.117Z] 06:43:15     INFO -      esi = 0x001be70c   edi = 0x001be680
[task 2020-07-18T06:43:15.117Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.118Z] 06:43:15     INFO -  18  xul.dll!truncf + 0x133aa28
[task 2020-07-18T06:43:15.118Z] 06:43:15     INFO -      eip = 0x5c435530   esp = 0x001be718   ebp = 0x001be77c   ebx = 0x001be70c
[task 2020-07-18T06:43:15.119Z] 06:43:15     INFO -      esi = 0x001be700   edi = 0x100b0f18
[task 2020-07-18T06:43:15.119Z] 06:43:15     INFO -      Found by: call frame info with scanning
[task 2020-07-18T06:43:15.120Z] 06:43:15     INFO -  19  0x2ec50b9e
[task 2020-07-18T06:43:15.120Z] 06:43:15     INFO -      eip = 0x2ec50b9e   esp = 0x001be784   ebp = 0x001be7b8
[task 2020-07-18T06:43:15.120Z] 06:43:15     INFO -      Found by: previous frame's frame pointer
[task 2020-07-18T06:43:15.121Z] 06:43:15     INFO -  20  xul.dll!js::jit::MaybeEnterJit(JSContext*, js::RunState&) [Jit.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 196 + 0x3d6]
[task 2020-07-18T06:43:15.121Z] 06:43:15     INFO -      eip = 0x59b53da3   esp = 0x001be7c0   ebp = 0x001be990
[task 2020-07-18T06:43:15.122Z] 06:43:15     INFO -      Found by: previous frame's frame pointer
[task 2020-07-18T06:43:15.122Z] 06:43:15     INFO -  21  xul.dll!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 441 + 0x7]
[task 2020-07-18T06:43:15.123Z] 06:43:15     INFO -      eip = 0x58cb0b05   esp = 0x001be998   ebp = 0x001be9c0   ebx = 0x0c225f91
[task 2020-07-18T06:43:15.123Z] 06:43:15     INFO -      esi = 0x0c214000   edi = 0x001be9e0
[task 2020-07-18T06:43:15.124Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.124Z] 06:43:15     INFO -  22  xul.dll!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 611 + 0x9]
[task 2020-07-18T06:43:15.124Z] 06:43:15     INFO -      eip = 0x58cc3e56   esp = 0x001be9c8   ebp = 0x001bea28   ebx = 0x001be9e0
[task 2020-07-18T06:43:15.125Z] 06:43:15     INFO -      esi = 0x001beb70   edi = 0x00000000
[task 2020-07-18T06:43:15.125Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.125Z] 06:43:15     INFO -  23  xul.dll!InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 639 + 0xc]
[task 2020-07-18T06:43:15.126Z] 06:43:15     INFO -      eip = 0x58cc5435   esp = 0x001bea30   ebp = 0x001bea68   ebx = 0x001bea48
[task 2020-07-18T06:43:15.126Z] 06:43:15     INFO -      esi = 0x001beba0   edi = 0x001beb70
[task 2020-07-18T06:43:15.127Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.127Z] 06:43:15     INFO -  24  xul.dll!js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [Interpreter.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 656 + 0x6]
[task 2020-07-18T06:43:15.128Z] 06:43:15     INFO -      eip = 0x58cc5671   esp = 0x001bea70   ebp = 0x001bea80   ebx = 0x0c214000
[task 2020-07-18T06:43:15.128Z] 06:43:15     INFO -      esi = 0x001beb70   edi = 0x0c248050
[task 2020-07-18T06:43:15.128Z] 06:43:15     INFO -      Found by: call frame info
[task 2020-07-18T06:43:15.129Z] 06:43:15     INFO -  25  xul.dll!js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName *>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [SelfHosting.cpp:0cc074b94631e41462e8b4a466bdb0a50d68c4f6 : 1688 + 0x18]
[task 2020-07-18T06:43:15.129Z] 06:43:15     INFO -      eip = 0x59007ebb   esp = 0x001bea88   ebp = 0x001bead4   ebx = 0x0c214000
[task 2020-07-18T06:43:15.130Z] 06:43:15     INFO -      esi = 0x0c23d048
[task 2020-07-18T06:43:15.130Z] 06:43:15     INFO -      Found by: call frame info
...

Flags: needinfo?(honzab.moz)

Bogdan Tara[:bogdan_tara | bogdant]

Comment 14

•

4 years ago

Also seeing these failures starting with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310256332&repo=autoland&lineNumber=1276
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310256307&repo=autoland&lineNumber=2303

Honza Bambas (:mayhemer)

Assignee

Comment 15

•

4 years ago

OK, so at CookieService::AddNative we are passing nullptr as a URI. I think it's fine to change the assertion to a non-null check and early exit.

Honza Bambas (:mayhemer)

Assignee

Comment 16

•

4 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=Q9_wmmCZQPOeLmLiuWOnmA.0&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=0e968ece9809f5d94905cc607ac445bc4526af3e

Flags: needinfo?(honzab.moz)

Pulsebot

Comment 17

•

4 years ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/cd05ec275e21
Emit warning to console when rejecting to set cookie, r=baku,flod

Andreea Pavel [:apavel]

Comment 18

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/cd05ec275e21

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox80: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla80

Olli Pettay [:smaug][bugs@pettay.fi]

Updated

•

4 years ago

Regressions: 1654585

Robert Longson [:longsonr]

Updated

•

4 years ago

Regressions: 1676651

Tom Schuster (MoCo)

Updated

•

2 years ago

Blocks: 1770772