1596770 - Add '--enable-fission' command line argument to 'mach marionette-test'

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task)

Description

[Marian Raiciof [:marauder]]

I created this bug after Henrik's request from :
https://phabricator.services.mozilla.com/D48660#inline-320565

If there is something needed by AWSY or another harness which is based on Marionette can you please file a separate issue first? That way we can get it properly implemented in Marionette first, and make it available for others too.

Here some things to care about in the new bug to be filed:

1. We want a proper solution for Marionette harness (including the mach marionette-test command), which isn't working here, because --enable-fission isn't a known option for Marionette. It means the implementation of it should happen in the lowest possible part of the stack, which is not AWSY but Marionette.

2. I don't expect to see references to other test harnesses in Marionette code. All of those can override certain methods and properties of Marionette classes to customize the behavior. Also references to Treeherder are out of place here. This tool is a couple of layers above Marionette.

3. Have a look at eg. --disable-e10s how it has to be implemented for Marionette.

4. When you file the new bug please mark it blocking bug 1518468.

Comment 1

[Marian Raiciof [:marauder]]

Attachment: Bug 1596770 - Add '--enable-fission' command line argument to 'mach marionette-test'

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[Marian Raiciof [:marauder]]

Attachment: Marionette_tests_fission.png

Comment 4

[Marian Raiciof [:marauder]]

Henrik,

I added 'fission.autostart' to self.prefs dictionary and I modified locally the marionette tests, to be able to check the 'about:config' settings:
for 'mach marionette-test' -> fission.autostart = False
for 'mach marionette-test --enable-fission' -> fission.autostart = True

I attached an image above.
Let me know if it's all good, to proceed with the "Enable Fission for Awsy" task.
Thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, that sounds fine. Thanks for the update. I hope to get to your review request soon.

Comment 6

[Marian Raiciof [:marauder]]

I finished the last required changes : https://phabricator.services.mozilla.com/D53205#1639035

What do you think about the behavior described in this comment :
https://phabricator.services.mozilla.com/D48660#1618549 ?

Thanks!

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marian, there is no need to set needinfo if a review is open for that. It only adds a double flag. Thanks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44656d71c606
Add '--enable-fission' command line argument to 'mach marionette-test' r=whimboo,marionette-reviewers

Comment 9

[Chris Peterson [:cpeterson]]

Blocks enabling Fission in Nightly (M6)

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/44656d71c606