1596772 - The OffscreenCanvas case of WebGLContext doesn't implement GetParentObject correctly

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P5)

Description

[Boris Zbarsky [:bzbarsky]]

nsICanvasRenderingContextInternal::GetParentObject just returns mCanvasElement. This means it returns null in the OffscreenCanvas case, right?

It might be better to have this GetParentObject return an nsIGlobalObject* and get it from either mCanvasElement or mOffscreenCanvas as needed.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Yes, that sounds better.

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1596772 - Make nsICanvasRenderingContextInternal::GetParentObject off-screen compatible. r?aosmond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06c7b4e2d14b
Make nsICanvasRenderingContextInternal::GetParentObject off-screen compatible. r=aosmond

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/06c7b4e2d14b