1596790 - Enable the test browser_thirdPartyIframe.js for fission

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, task, P3)

Description

[Neil Deakin]

The comment in browser.ini says that test is disabled due to bug 1576915 but that bug is fixed and the test is still not working.

The following is printed:

"uncaught exception: Video is being cloned visually. - timed out after 50 tries."

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I suspect that comment should be updated so that it is enabled once bug 1575868 is fixed - since it turns out that porting to JSWindowActors isn't enough to make PiP Fission-compatible.

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[Chris Peterson [:cpeterson]]

mconley says PiP needs to be made Fission compatible before this test can be fixed. PiP blocks enabling Fission in Nightly (M6), so I will move this bug from milestone M4.1 to M6.

Comment 4

[Chris Peterson [:cpeterson]]

Tracking for Fission milestone M6c because making PiP Fission-compatible blocks enabling Fission in Nightly.

This test is still skipped on Fission:

[browser_thirdPartyIframe.js]
skip-if = fission # Bug 1576915

https://searchfox.org/mozilla-central/rev/46e3b1ce2cc120a188f6940b5c6eab6b24530e4f/toolkit/components/pictureinpicture/tests/browser.ini#45-46

Comment 5

[Neha Kochar [:neha]]

PiP is M6b

Comment 6

[Mike Conley (:mconley) (:⚙️)]

This should be fixed when bug 1648107 closes.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

This test was enabled in bug 1648107.