Closed
Bug 1596807
Opened 5 years ago
Closed 5 years ago
disable -Wmicrosoft-exception-spec
Categories
(Firefox Build System :: General, task)
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
As switching to C++17 starts throwing these warnings all over the place.
|
Assignee | |
Comment 1•5 years ago
|
||
Documenting for posterity the error here in a little more detail.
We have headers that declare COM methods like
IFACEMETHOD(DrawGlyphRun)
which expands to
__override virtual COM_DECLSPEC_NOTHROW HRESULT STDMETHODCALLTYPE DrawGlyphRun
but then the definition uses
IFACEMETHODIMP DWriteFontFallbackRenderer::DrawGlyphRun(
which expands to
__override HRESULT STDMETHODCALLTYPE DWriteFontFallbackRenderer::DrawGlyphRun(
Note the missing COM_DECLSPEC_NOTHROW.
See also https://github.com/google/skia/commit/6cb6a07116c986719bb9acb5125b92bd9f3e068a and https://developercommunity.visualstudio.com/content/problem/325764/msvc-1582-generates-warning-c4986-in-atl-header-fi.html
|
||
Updated•5 years ago
|
Type: defect → task
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5173fdbd7c6 turn off more exception spec mismatch warnings on Windows; r=dmajor
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Updated•5 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•