Closed
Bug 1596820
Opened 3 years ago
Closed 3 years ago
Remove use of nsIDocShellTreeItem in nsDocShellLoadState::SetupInheritingPrincipal
Categories
(Core :: DOM: Navigation, task, P3)
Core
DOM: Navigation
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Depends on 2 open bugs, Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
In file docshell/base/nsDocShellLoadState.cpp
Trivial use of ItemType for nsIDocShellTreeItem
Change to use BrowsingContext::Type
Needs change to users.
Updated•3 years ago
|
Blocks: rm-docshell-tree-item
Type: defect → task
Fission Milestone: --- → M6
Priority: -- → P3
Summary: DummyBug NAME= nsDocShellLoadState::SetupInheritingPrincipal → Remove use of nsIDocShellTreeItem in nsDocShellLoadState::SetupInheritingPrincipal
Assignee | ||
Comment 1•3 years ago
|
||
nsDocShellLoadState::SetupInheritingPrincipal()
would be passed the value ofnsDocShell::mItemType
.- This
nsDocShell::mItemType
is a private member ofnsDocShell
. nsDocShell::mItemType
is only initialized withnsIDocShellTreeItem::typeContent
ornsIDocShellTreeItem::typeChrome
.
By these things, I suspect we can replace the type of nsDocShell::mItemType
with BrowsingContext::Type
safely, but there are some exceptions.
I seem we should add a getter function like nsDocShell::BrowsingContextType()
conservatively, or wait to resolve other bugs to remove nsIDocShellTreeItem
.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Attachment #9116126 -
Attachment is obsolete: true
Pushed by tetsuharu.ohzeki@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b7f7c1445def part 1: Implement BrowsingContext::GetType(). r=kmag https://hg.mozilla.org/integration/autoland/rev/2a509ad44c1c part 2: Remove use of nsIDocShellTreeItem in nsDocShellLoadState::SetupInheritingPrincipal. r=kmag
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b7f7c1445def
https://hg.mozilla.org/mozilla-central/rev/2a509ad44c1c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•