1596820 - Remove use of nsIDocShellTreeItem in nsDocShellLoadState::SetupInheritingPrincipal

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Kannan Vijayan [:djvj]]

In file docshell/base/nsDocShellLoadState.cpp

Trivial use of ItemType for nsIDocShellTreeItem
Change to use BrowsingContext::Type
Needs change to users.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

• nsDocShellLoadState::SetupInheritingPrincipal() would be passed the value of nsDocShell::mItemType.
• This nsDocShell::mItemType is a private member of nsDocShell.
• nsDocShell::mItemType is only initialized with nsIDocShellTreeItem::typeContent or nsIDocShellTreeItem::typeChrome.
  • https://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_nsDocShell%3E_mItemType&redirect=false
  • https://searchfox.org/mozilla-central/rev/6bceafe72cad5d5752667b4b6bd595d3a4047ca3/docshell/base/nsDocShell.cpp#320

By these things, I suspect we can replace the type of nsDocShell::mItemType with BrowsingContext::Type safely, but there are some exceptions.

I seem we should add a getter function like nsDocShell::BrowsingContextType() conservatively, or wait to resolve other bugs to remove nsIDocShellTreeItem.

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1596820 - part 1: Implement nsDocShell::BrowsingContextType().

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1596820 - part 2: Remove use of nsIDocShellTreeItem in nsDocShellLoadState::SetupInheritingPrincipal.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1596820 - part 1: Implement BrowsingContext::GetType().

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7f7c1445def
part 1: Implement BrowsingContext::GetType(). r=kmag
https://hg.mozilla.org/integration/autoland/rev/2a509ad44c1c
part 2: Remove use of nsIDocShellTreeItem in nsDocShellLoadState::SetupInheritingPrincipal. r=kmag

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b7f7c1445def
https://hg.mozilla.org/mozilla-central/rev/2a509ad44c1c