1596858 - Different spacing above "Enabled" and "Disabled" headers when there is no enabled add-on

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[:Gijs (he/him)]

STR:

1. clean profile
2. open about:addons
3. install one of the suggested add-ons
4. disable the suggested add-on

ER:
there's no vertical shift in the position of the add-on, because the "enabled" header swaps with a "disabled" header, and the size of the add-on card will stay the same

AR:
the disabled header has more space above it than the enabled one, leading to an unpleasant shift in the page.

I'm aware fixing bug 1593358 will make this better, but it'd still be nice to fix this for visual consistency, IMO. :-)

Comment 1

[Mark Striemer [:mstriemer]]

While we're fixing margin on headings, the Recommended Themes heading is missing some bottom margin, I think because we expect the margin to be on the message bar that appears under the Recommended Extensions heading.

Comment 2

[aarushivij]

Hello,
Can I work on this issue?
Thanks :)
Aarushi

Comment 3

[Mark Striemer [:mstriemer]]

Yes, you're welcome to work on this! Currently there are rules [1] to set a margin-top except for the first heading, but that should instead likely be setting a margin-bottom for the sections themselves. Thanks!

[1] https://searchfox.org/mozilla-central/rev/d6f957415cf009995ecb539ef1425316d82164a9/toolkit/mozapps/extensions/content/aboutaddons.css#104,108-111

Comment 4

[aarushivij]

Attachment: Bug 1596858 - Different spacing above Enabled and Disabled headers while there is no enabled add-on r=mstriemer

Comment 5

[aarushivij]

Hi Mark, I have pushed the patch.
Please review
Shall make the changes if any :)
Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8f6b2875121
Different spacing above Enabled and Disabled headers while there is no enabled add-on r=mstriemer

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e8f6b2875121

Comment 8

[Caitlin Neiman [:caitmuenster]]

Thanks so much for the patch, Aarushi! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!

Comment 9

[aarushivij]

Thanks Caitlin, it really boosted my confidence alot :)
Also would love to create an account on mozillians.org :)
Any links how can I create the account
Thanks :)
Aarushi

Comment 10

[Caitlin Neiman [:caitmuenster]]

Sure thing! Click on the button on the upper right that says "Log In / Sign up" to create an account. Once you're set up, leave another comment in this bug with the URL of your profile and I'll vouch for you. 👍

Comment 11

[aarushivij]

https://mozillians.org/en-GB/u/aarushivij/

Comment 12

[Caitlin Neiman [:caitmuenster]]

Awesome! Thanks Aarushi. You're all vouched. :)

Welcome onboard! I look forward to seeing you around.

Comment 13

[aarushivij]

Thanks :)