Closed Bug 1596925 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 20283 - Change key code to "MetaLeft" and "MetaRight" for "Meta" keys

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20283 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20283
Details from upstream follow.

Lan Wei <lanwei@chromium.org> wrote:

Change key code to "MetaLeft" and "MetaRight" for "Meta" keys

According to the key event spec,
https://www.w3.org/TR/uievents-code/#key-alphanumeric-functional, the
key code for the left and right "Meta" keys should be "MetaLeft" and
"MetaRight" not "OSLeft" and "OSRight". Now, we should update them for
the wpt key tests.

I created an issue on webdriver github:
https://github.com/w3c/webdriver/issues/1457

Bug: 1023962
Change-Id: Iff1a678c991d9c6d3733c22a481cbb653b23df0c

Reviewed-on: https://chromium-review.googlesource.com/1913103
WPT-Export-Revision: 2ff85beeb0c5ffb08409d512fe2aa4edabe75862

Component: web-platform-tests → geckodriver
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/caa4f29d794c
[wpt PR 20283] - Change key code to "MetaLeft" and "MetaRight" for "Meta" keys, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a15b7ea271cd
[wpt PR 20283] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.