1596937 - Edit calendar dialog no email warning is clipped

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect, P3)

Description

[Paul Morris [:pmorris]]

Attachment: Edit-Calendar-dialog-glitch.png

On trunk if you edit a calendar's properties and select "none" for "email" the warning that appears at the top is now clipped. Possibly related to de-grid work in bug 1568660 but I don't think it was doing this when that landed.

Comment 1

[Khushil Mistry [:khushil324]]

It is may be related to Bug 1588694. I will look into it.

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1596937_fixed-edit-calendar-warning.patch

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9109786 [details] [diff] [review]
Bug-1596937_fixed-edit-calendar-warning.patch

Review of attachment 9109786 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and fixes the clipping, thanks!

Comment 4

[Jorg K (CEST = GMT+2)]

Paul, can you also look at the commit message in the future. I always have to correct them :-(
Fixed + <bug summary> is mostly bad grammar. Here I'm going for:
Fixed clipping of "no email warning" when editing calendar properties

Comment 5

[Paul Morris [:pmorris]]

Jorg, ah, OK. Will do on checking commit messages in future. Thanks for the tip.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dbf07a17aee3
Fixed clipping of "no email warning" when editing calendar properties. r=pmorris