Closed Bug 1596937 Opened 5 months ago Closed 4 months ago

Edit calendar dialog no email warning is clipped

Categories

(Calendar :: Dialogs, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmorris, Assigned: khushil324)

Details

Attachments

(1 file, 1 obsolete file)

Attached image Edit-Calendar-dialog-glitch.png (obsolete) —

On trunk if you edit a calendar's properties and select "none" for "email" the warning that appears at the top is now clipped. Possibly related to de-grid work in bug 1568660 but I don't think it was doing this when that landed.

Assignee: nobody → khushil324

It is may be related to Bug 1588694. I will look into it.

Attachment #9109163 - Attachment is obsolete: true
Attachment #9109786 - Flags: review?(paul)
Status: NEW → ASSIGNED
Comment on attachment 9109786 [details] [diff] [review]
Bug-1596937_fixed-edit-calendar-warning.patch

Review of attachment 9109786 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and fixes the clipping, thanks!
Attachment #9109786 - Flags: review?(paul) → review+

Paul, can you also look at the commit message in the future. I always have to correct them :-(
Fixed + <bug summary> is mostly bad grammar. Here I'm going for:
Fixed clipping of "no email warning" when editing calendar properties

Jorg, ah, OK. Will do on checking commit messages in future. Thanks for the tip.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dbf07a17aee3
Fixed clipping of "no email warning" when editing calendar properties. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 72
You need to log in before you can comment on or make changes to this bug.