android-build image needs valgrind for address sanitizer builds
Categories
(Firefox Build System :: Task Configuration, enhancement)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: truber, Assigned: truber)
References
Details
Attachments
(1 file)
Valgrind is a build requirement for ASAN builds. Valgrind should be added to the android-build docker image.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/635be62762b9 Add valgrind to android-build image. r=froydnj
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
(In reply to Jesse Schwartzentruber (:truber) from comment #0)
Valgrind is a build requirement for ASAN builds.
O_o Can you elaborate?
|
|
Assignee | |
Comment 5•4 years ago
|
||
It was originally added in bug 753135 and has been in every ASAN mozconfig since. I asked Christian about this a while ago:
[2017-07-19 14:05:15] <truber> do you know the reason for needing --enable-valgrind for asan builds?
[2017-07-19 15:37:07] <decoder> Yes, the reason is that it enables a bunch of code that tries to avoid seemingly bad memory access (eg in GC)
[2017-07-19 15:37:19] <decoder> But I'm not sure if it is actually required nowadays
So it used to be required to change some GC behaviour, and it's been easier to carry it forward than to check whether that's still true (or fix the defines). Even so, it sounds like only the defines were required and not the tool itself.
Description
•