Closed Bug 1596973 Opened 5 years ago Closed 5 years ago

Improve FlexContainer's logging facility

Categories

(Core :: Layout: Flexbox, task)

task
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file)

It is a bit awkward to use MOZ_LOG directly in nsFlexContainerFrame. We should make it easier to use by adding a wrapper.

It is a bit awkward to use raw MOZ_LOG directly, so I added FLEX_LOG()
to easily add printf() style logs.

"\n" is not need because MOZ_LOG() already appends one.

I hope it is OK to change the log module name to "FlexContainer". It's
shorter to type either by using

MOZ_LOG=FlexContainer:debug ./mach run or by setting

logging.FlexContainer=debug in [runprefs] section in ~/.mozbuild/machrc

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e6bc09bed1cf
Improve FlexContainer's logging facility. r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: