Closed Bug 1597005 Opened 1 year ago Closed 1 year ago

Create a task to test gdb prettyprinters

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(9 files, 1 obsolete file)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Creating a new bug since bug 1255476 has a bunch of old stuff that has now landed.

I have this mostly working, but the gdb I'm getting on taskcluster is rather old. Or more to the point, the Python embedded in it is 3.2.3, which doesn't handle unicode string literals (like u'foo'), which the prettyprinter code is using.

(copied from IRC)

glandium: the gdb I get seems to have python 3.2.3 embedded in it. Is something that old going to be on developer's machines? Our code assumes something newer. It's barfing because it can't handle unicode literal syntax, eg u”

this is gdb 7.12-6.deb7moz1

Current state: https://treeherder.mozilla.org/#/jobs?repo=try&author=sfink%40mozilla.com&selectedJob=276544130

Flags: needinfo?(mh+mozilla)

If you want something more recent, try a debian10 build image. Otherwise, unicode strings are the default in python3, so you don't actually need u"" syntax. If you're using that for python2 compat, then you should use from __future__ import unicode_literals instead.

Flags: needinfo?(mh+mozilla)
Assignee: nobody → sphink

Note that the gdb variant excludes the unwinder tests for now. They require more fixups that I did not want to delve into for the automated test.

(In reply to Mike Hommey [:glandium] (high latency) from comment #2)

If you want something more recent, try a debian10 build image.

I probably should have done this, rather than fixing all the Python 3.2 bugs. But I guess it's good to support people running old versions.

Otherwise, unicode strings are the default in python3, so you don't actually need u"" syntax. If you're using that for python2 compat, then you should use from __future__ import unicode_literals instead.

For now, I'm dropping Python2 support until I get evidence that someone is still running on a system with a gdb that embeds python2. (I was until ~3 years ago, but I'm hoping they're all gone now.)

Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/124766c078e2
Put ExecutableAllocator prettyprinter back and fix it up r=jimb
https://hg.mozilla.org/integration/autoland/rev/7dac8fdaeada
Switch autospider.py to be run with python3. r=jimb
https://hg.mozilla.org/integration/autoland/rev/89dd6ea71d80
Python 3.2 compatibility - work around concurrent .pyc file writes and remove useless u'' literal r=jimb
https://hg.mozilla.org/integration/autoland/rev/1cd0d40914b6
Fix test that requires not looking through base class typedef r=jimb
https://hg.mozilla.org/integration/autoland/rev/1e511ad72b2d
Rebase gdb test over removal of flat strings. r=jimb
https://hg.mozilla.org/integration/autoland/rev/e050ede804bb
Handle PropertyKey r=jimb
https://hg.mozilla.org/integration/autoland/rev/159a37cef898
Implement an optional gdb test target in autospider.py r=jimb
https://hg.mozilla.org/integration/autoland/rev/48267c5a8d23
Add taskcluster job to run gdb prettyprinter tests r=glandium
https://hg.mozilla.org/integration/autoland/rev/eb0d6b29ae1d
Prevent -Werror failure for bogus printf overflow warning in ZydisAPI.cpp with gcc -O0 r=lth
Attachment #9110713 - Attachment is obsolete: true
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b322e1ed34b5
autospider.py: Run with Python3
https://hg.mozilla.org/integration/autoland/rev/0e47d29ad5c9
Put ExecutableAllocator prettyprinter back and fix it up r=jimb
https://hg.mozilla.org/integration/autoland/rev/669afb16a3f8
Python 3.2 compatibility - work around concurrent .pyc file writes and remove useless u'' literal r=jimb
https://hg.mozilla.org/integration/autoland/rev/e30c4e8a4c6e
Fix test that requires not looking through base class typedef r=jimb
https://hg.mozilla.org/integration/autoland/rev/cdc8e116fada
Rebase gdb test over removal of flat strings. r=jimb
https://hg.mozilla.org/integration/autoland/rev/161711b6d75a
Handle PropertyKey r=jimb
https://hg.mozilla.org/integration/autoland/rev/dcf95af6615b
Implement an optional gdb test target in autospider.py r=jimb
https://hg.mozilla.org/integration/autoland/rev/f0986bebbb22
Add taskcluster job to run gdb prettyprinter tests r=glandium
https://hg.mozilla.org/integration/autoland/rev/5a7641c75a2e
Prevent -Werror failure for bogus printf overflow warning in ZydisAPI.cpp with gcc -O0 r=glandium,lth
Flags: needinfo?(sphink)
You need to log in before you can comment on or make changes to this bug.