Create a task to test gdb prettyprinters
Categories
(Core :: JavaScript Engine, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(9 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1597005 - Prevent -Werror failure for bogus printf overflow warning in ZydisAPI.cpp with gcc -O0
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Creating a new bug since bug 1255476 has a bunch of old stuff that has now landed.
I have this mostly working, but the gdb I'm getting on taskcluster is rather old. Or more to the point, the Python embedded in it is 3.2.3, which doesn't handle unicode string literals (like u'foo'
), which the prettyprinter code is using.
Assignee | ||
Comment 1•5 years ago
|
||
(copied from IRC)
glandium: the gdb I get seems to have python 3.2.3 embedded in it. Is something that old going to be on developer's machines? Our code assumes something newer. It's barfing because it can't handle unicode literal syntax, eg u”
this is gdb 7.12-6.deb7moz1
Current state: https://treeherder.mozilla.org/#/jobs?repo=try&author=sfink%40mozilla.com&selectedJob=276544130
Comment 2•5 years ago
|
||
If you want something more recent, try a debian10 build image. Otherwise, unicode strings are the default in python3, so you don't actually need u"" syntax. If you're using that for python2 compat, then you should use from __future__ import unicode_literals
instead.
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Assignee | ||
Comment 9•5 years ago
|
||
Note that the gdb variant excludes the unwinder tests for now. They require more fixups that I did not want to delve into for the automated test.
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
(In reply to Mike Hommey [:glandium] (high latency) from comment #2)
If you want something more recent, try a debian10 build image.
I probably should have done this, rather than fixing all the Python 3.2 bugs. But I guess it's good to support people running old versions.
Otherwise, unicode strings are the default in python3, so you don't actually need u"" syntax. If you're using that for python2 compat, then you should use
from __future__ import unicode_literals
instead.
For now, I'm dropping Python2 support until I get evidence that someone is still running on a system with a gdb that embeds python2. (I was until ~3 years ago, but I'm hoping they're all gone now.)
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
Backed out for SM bustages on autospider.py
Backout link: https://hg.mozilla.org/integration/autoland/rev/3a9f7aa3da7dcf00b03584211629238846eaf7b4
Log link 1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281423042&repo=autoland&lineNumber=225
Log link 2: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281421751&repo=autoland&lineNumber=7730
There was also a flake8 failure on ExecutableAllocator.py -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281420717&repo=autoland&lineNumber=52
Comment 15•5 years ago
|
||
Also bustages on test-prettyprinters
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281421156&repo=autoland&lineNumber=64329
Assignee | ||
Comment 16•5 years ago
|
||
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b322e1ed34b5
https://hg.mozilla.org/mozilla-central/rev/0e47d29ad5c9
https://hg.mozilla.org/mozilla-central/rev/669afb16a3f8
https://hg.mozilla.org/mozilla-central/rev/e30c4e8a4c6e
https://hg.mozilla.org/mozilla-central/rev/cdc8e116fada
https://hg.mozilla.org/mozilla-central/rev/161711b6d75a
https://hg.mozilla.org/mozilla-central/rev/dcf95af6615b
https://hg.mozilla.org/mozilla-central/rev/f0986bebbb22
https://hg.mozilla.org/mozilla-central/rev/5a7641c75a2e
Assignee | ||
Updated•5 years ago
|
Description
•