Closed Bug 1597084 Opened 2 years ago Closed 7 months ago

The Favicons on the Bookmarks Bar flicker when starting Firefox or opening a new Window

Categories

(Firefox :: Bookmarks & History, defect, P5)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- verified

People

(Reporter: mehmet.sahin, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Favicons_Flicker.mov
452.54 KB, video/quicktime
Details
Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon.
47 bytes, text/x-phabricator-request
Details | Review
Attached video Favicons_Flicker.mov —

Nightly 72.0a1 (2019-11-16) (64-Bit)

1.) Add some bookmarks to your Bookmarks Bar
2.) Start Firefox or open a new Window

Actual: The Favicons on the Bookmarks Bar flicker when starting Firefox or opening a new Window

Expected: The Favicons should not flicker on the Bookmarks Bar.

A screencast is attached.

Thanks.

Is this a regression that started happening recently, or has it always been like that?

Flags: needinfo?(mehmet.sahin)

(In reply to Marco Bonardo [:mak] from comment #1)

Is this a regression that started happening recently, or has it always been like that?

Happens also in Firefox Stable 70.0.1 (64-Bit). So seems not to be a recent regression, but would be very nice to have an higher priority to fix this, since this is a visual distraction :-(

Thanks in advance.

Why it is not possible to remove the needinfo flag?

Flags: needinfo?(mehmet.sahin)

(In reply to Mehmet from comment #3)

Why it is not possible to remove the needinfo flag?

Ah, sorry for the spam - finally done !

Component: Theme → Bookmarks & History

Hm, well the icons are loaded asynchronously, thus I'm not sure there's a simple fix for this on our side...
Ideas are welcome.

Priority: -- → P5
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc5b59f19316
Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak

https://hg.mozilla.org/mozilla-central/rev/cc5b59f19316

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
QA Whiteboard: [qa-84b-p2]

Hello,

Verified on Fx 84.0b4 on Windows 10x64, Ubuntu 18.04 and macOS 10.15

Status: RESOLVED → VERIFIED
status-firefox84: fixed → verified
You need to log in before you can comment on or make changes to this bug.