1597130 - MsgNewFolder seems unused

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Ian Neal]

The callers for MsgNewFolder function in mailWindowOverlay.js were removed back in Bug 414038 but the function itself was left behind. Was it left for a reason (e.g. extension use) or forgotten?
If forgotten, then also the function getDestinationFolder could possibly removed as MsgNewFolder is the only caller of that function.

Comment 1

[Jorg K (CEST = GMT+2)]

Care to do some clean-up here?

Comment 2

[:aceman]

Sure. Ian, do you mean the Thunderbird version of the function, as in Seamonkey it is still used?

Comment 3

[Ian Neal]

(In reply to :aceman from comment #2)

Sure. Ian, do you mean the Thunderbird version of the function, as in Seamonkey it is still used?
Yes, just the TB version. SM version is still in use, currently.

Comment 4

[:aceman]

Attachment: 1597130.patch

Seems to work, try run at
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=36c6dc8162a3571b64f1953d2f12794eaf731687

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9109782 [details] [diff] [review]
1597130.patch

I love deletions.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f5bd174b047b
remove unused MsgNewFolder() in mail/base/content/mailWindowOverlay.js. r=jorgk