1597163 - Cache address book lists and cards

Status: RESOLVED FIXED

(MailNews Core :: Address Book, task)

Description

[Geoff Lankow (:darktrojan)]

A lot of repeated main thread I/O can be prevented if we remember the cards in a directory and their properties. It also saves scanning the entire properties table for each card. The downside is using a bit more memory but I think it is worth it.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1597163-addrbook-cache-1.diff

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1597163-addrbook-cache-1.diff

Now without the code I used to check this was actually doing something worthwhile.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1597163-addrbook-cache-2.diff

Now with the right file. This is going well. :-/

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9109344 [details] [diff] [review]
1597163-addrbook-cache-2.diff

Review of attachment 9109344 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/addrbook/jsaddrbook/AddrBookDirectory.jsm
@@ +322,5 @@
>      return card.QueryInterface(Ci.nsIAbCard);
>    },
>    _loadCardProperties(uid) {
> +    if (this._inner.hasOwnProperty("_cards")) {
> +      let cachedCard = this._cards.get(uid);

should this (preferably) be this._inner._cards? same below

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d5118af449e7
Cache address book lists and cards; r=mkmelin

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1597163-addrbook-cache-3.diff

Assuming there are no regressions…

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9109891 [details] [diff] [review]
1597163-addrbook-cache-3.diff

That's the beta patch?

Comment 8

[Geoff Lankow (:darktrojan)]

That's the patch I landed with the review comments addressed. I assume it works on beta.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 71 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/a742266bad39219d922edc84559f6f77d0045e1c