Closed Bug 1597190 Opened 5 months ago Closed 4 months ago

Remove setting of "extensions.showMismatchUI" preference from Marionette

Categories

(Testing :: Marionette, task)

Version 3
task
Not set

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: whimboo, Assigned: hawkin55, Mentored)

References

Details

(Whiteboard: [lang=py])

User Story

Please check the following URL in how to get started:
https://firefox-source-docs.mozilla.org/testing/marionette/Contributing.html

Attachments

(1 file)

In geckoinstance.py we still set the preferences for extensions.showMismatchUI to a custom value:

https://searchfox.org/mozilla-central/rev/524bed6dfbc5ae21c62632d83b7573448b29e0ac/testing/marionette/client/marionette_driver/geckoinstance.py#74-75

This is not necessary anymore given the those preferences have been removed with Firefox 61 (bug 1433574).

Those lines can simply be removed. Please make sure to also run the unit tests under testing/marionette/harness/marionette_harness/tests/unit to ensure nothing is broken:

./mach marionette-test %path_to_tests%

Hi, looking for a new bug. Think i could take this on?

Flags: needinfo?(hskupin)

Yes, totally! Feel free to pick it and submit a patch. I will assign the bug to you once it has been uploaded. Thanks a lot. Also let me know if you have questions.

Flags: needinfo?(hskupin)

Hi made the local changes (removing the line of code), i tried, hg build and an error come up as "config object not found by mach". wandering if you know what may have caused this? the code was building before.

(In reply to Elliot Matthew from comment #3)

Hi made the local changes (removing the line of code), i tried, hg build and an error come up as "config object not found by mach". wandering if you know what may have caused this? the code was building before.

Not seen that before, but try pulling from latest central and rebasing. Then run ./mach bootstrap to ensure the development environment has the necessary dependencies, and try ./mach clobber && ./mach build again.

If this doesn’t resolve your build problem, try reaching out to one of us in #interop on IRC.

Assignee: nobody → hawkin55
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a960f4ebc0c6
Remove setting of 'extensions.showMismatchUI' preference from Marionette, r=whimboo,marionette-reviewers
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.