1597191 - Avoid errors in processing preloaded cursor entries to cause an overall error

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P2)

Description

[Simon Giesecke [:sg] [he/him]]

By https://searchfox.org/mozilla-central/rev/cac340f10816707e91c46db6d285f80259420f07/dom/indexedDB/ActorsParent.cpp#25950, we may fail when processing preloaded entries, causing an error which would not be present when processing the original entry only. This should be avoided to ensure that preloading is completely transparent.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Removed redundant assertions. r=#dom-workers-and-storage

Assertions on the type of an IPDL-defined union before accessing it are redundant,
since the generated accessors already contain a MOZ_RELEASE_ASSERT for checking
the type. Redundant assertions unnecessarily clutter the code, so they are removed.

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Removed code duplication between response type cases. r=#dom-workers-and-storage

Depends on D53797

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Pull up SendSuccessResult to CursorOpBase to remove code duplication. r=#dom-workers-and-storage

Depends on D53798

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Added const where easily possible. r=#dom-workers-and-storage

Depends on D53799

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Remove cursor positions from Cursor state. r=#dom-workers-and-storage

Depends on D53800

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Remove duplication between OpenOp::Do*DatabaseWork functions. r=#dom-workers-and-storage

Depends on D53801

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1597191 - Do not fail cursor operation when processing preloaded entries. r=#dom-workers-and-storage

Depends on D53802

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d10108fdd91
Removed redundant assertions. r=dom-workers-and-storage-reviewers,ytausky

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8d10108fdd91

Comment 11

[Julien Cristau [:jcristau]]

What's the plan to fix this regression in 72, considering these patches aren't ready and we're basically at the end of 72 nightly?

Comment 12

[Simon Giesecke [:sg] [he/him]]

(In reply to Julien Cristau [:jcristau] from comment #11)

What's the plan to fix this regression in 72, considering these patches aren't ready and we're basically at the end of 72 nightly?

I am trying to get the patches reviewed this week. If no significant changes are necessary, I can land them by the end of the week.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3a4f25c761a
Removed code duplication between response type cases. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/124c6ad47ae6
Pull up SendSuccessResult to CursorOpBase to remove code duplication. r=dom-workers-and-storage-reviewers,edenchuang,asuth
https://hg.mozilla.org/integration/autoland/rev/d9f063b6ae43
Added const where easily possible. r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/a94d9e2ef3b0
Remove cursor positions from Cursor state. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/fcb930bb061e
Remove duplication between OpenOp::Do*DatabaseWork functions. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/13e47a0fe213
Do not fail cursor operation when processing preloaded entries. r=dom-workers-and-storage-reviewers,asuth

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a3a4f25c761a
https://hg.mozilla.org/mozilla-central/rev/124c6ad47ae6
https://hg.mozilla.org/mozilla-central/rev/d9f063b6ae43
https://hg.mozilla.org/mozilla-central/rev/a94d9e2ef3b0
https://hg.mozilla.org/mozilla-central/rev/fcb930bb061e
https://hg.mozilla.org/mozilla-central/rev/13e47a0fe213