Closed Bug 1597232 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20297 - [css-text] There is no shape-result when items overflow under break-word

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20297 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20297
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:

[css-text] There is no shape-result when items overflow under break-word

When the overflow-wrap: 'break-word' feature is used, items overflowing
don't have an associated ShapeResult instance, since we deliberately set
the kNoResultIfOverflow to ignore it because it will be rewound in any
case.

However, in the RewindOverflow function, we incorrectly assumed that
when an item has no associated ShapeResult, it shouldn't be a trailable
text item.

Additionally, this CL removes the clause that implied that items formed
with all trailable spaces should be ignored. Such logic prevented such
kind of items to hang, which is what the spec mandates when pre-wrap is
being used.

Bug: 1003184
Change-Id: Iab930be3ecc8e4dc814be25d902ecedabc70a944

Reviewed-on: https://chromium-review.googlesource.com/1919351
WPT-Export-Revision: bfe2490b94620de010f8ecdee3507911666c5200

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

PASS: 8

Chrome

PASS: 2
FAIL: 6

Safari

PASS: 8

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db1d5134a2eb
[wpt PR 20297] - [css-text] There is no shape-result when items overflow under break-word, a=testonly

https://hg.mozilla.org/mozilla-central/rev/db1d5134a2eb

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.