Move newtab-unit-tests out of `source-test`, as they require a build
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(Not tracked)
People
(Reporter: Pike, Unassigned)
References
Details
Bug 1567924 added the newtab tests to m-c automation.
It did so in source-test, which is misleading 'cause it's actually not a source-tests. I guess it should be moved into test.
It also copied the code-review attribute from other tests, which is used to control the tests run by reviewbot. It probably doesn't want to do that. Probably rarely a problem due to the files-changed filter, but a problem when all source tests get triggered.
|
||
Comment 1•5 years ago
|
||
The source-test name means that tests run from a source checkout + mach command (usually) rather than the traditional tests.zip + mozharness. It refers to how the tests are run and not what they test. There are already several source-test tasks that use builds, e.g:
https://searchfox.org/mozilla-central/rev/524bed6dfbc5ae21c62632d83b7573448b29e0ac/taskcluster/ci/source-test/python.yml#83
There's a super long term goal to try and migrate from the test way of doing things over to the source-test way of doing things. In fact looking at that patch, I likely would have r-'ed and asked to move it to the source-test kind had they put it in test :).
|
Reporter | |
Comment 2•5 years ago
|
||
So then code-review should be removed from the attributes at least, right?
|
||
Updated•2 years ago
|
Description
•