1597316 - Scroll is not prevented and keyup is required when navigating login list with keys

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Mark Striemer [:mstriemer]]

When navigating the login list with the up/down arrow keys, the list still scrolls. You can see the difference when using the left/right keys which also changes the selection but does not cause the same scrolling effect.

You are also required to let the key back up to navigate to the next item, rather than being able to hold the key down to keep moving the selection.

This looks like it was probably regressed by bug 1581014 which moved all the event handlers to keyup instead of just the space/enter one.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1597316 - Don't scroll login list on arrows, allow holding an arrow to navigate r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad32f331d00a
Don't scroll login list on arrows, allow holding an arrow to navigate r=MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a3d6472ad3e9
Don't scroll login list on arrows, allow holding an arrow to navigate r=MattN

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a3d6472ad3e9

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue and is no longer reproducible on the Firefox Beta 72.0b3 (Build ID: 20191205201734) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The Login List is not scrolled when navigating with the arrow keys.
• All the logins from the list are focused when pressing and holding the arrow keys.