1597364 - bitbar: script.py: handle ADBTimeoutError exceptions

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, enhancement)

Description

[Andrew Erickson [:aerickson]]

See gbrown's note in the following bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=1500266#c154

[task 2019-11-17T10:51:19.893Z] Connecting to Android device FA7AV1A03250
[task 2019-11-17T10:51:19.893Z] 2019-11-17 10:51:19,893 INFO Using adb 1.0.41
[task 2019-11-17T10:56:20.165Z] Traceback (most recent call last):
[task 2019-11-17T10:56:20.165Z]   File "/builds/taskcluster/script.py", line 235, in <module>
[task 2019-11-17T10:56:20.165Z]     sys.exit(main())
[task 2019-11-17T10:56:20.165Z]   File "/builds/taskcluster/script.py", line 173, in main
[task 2019-11-17T10:56:20.165Z]     device = ADBDevice(device=env['DEVICE_SERIAL'])
[task 2019-11-17T10:56:20.165Z]   File "/usr/local/lib/python2.7/dist-packages/mozdevice/adb.py", line 620, in __init__
[task 2019-11-17T10:56:20.178Z]     self._initialize_boot_state(timeout=timeout)
[task 2019-11-17T10:56:20.178Z]   File "/usr/local/lib/python2.7/dist-packages/mozdevice/adb.py", line 819, in _initialize_boot_state
[task 2019-11-17T10:56:20.178Z]     self._check_adb_root(timeout=timeout)
[task 2019-11-17T10:56:20.178Z]   File "/usr/local/lib/python2.7/dist-packages/mozdevice/adb.py", line 907, in _check_adb_root
[task 2019-11-17T10:56:20.178Z]     self._have_root_shell = self._check_root_user(timeout=timeout)
[task 2019-11-17T10:56:20.178Z]   File "/usr/local/lib/python2.7/dist-packages/mozdevice/adb.py", line 899, in _check_root_user
[task 2019-11-17T10:56:20.178Z]     if self.shell_output("id", timeout=timeout).find(uid) != -1:
[task 2019-11-17T10:56:20.178Z]   File "/usr/local/lib/python2.7/dist-packages/mozdevice/adb.py", line 1581, in shell_output
[task 2019-11-17T10:56:20.179Z]     raise ADBTimeoutError("%s" % adb_process)
[task 2019-11-17T10:56:20.179Z] mozdevice.adb.ADBTimeoutError: args: adb wait-for-device shell id; echo adb_returncode=$?, exitcode: None, stdout: uid=2000(shell) gid=2000(shell) groups=2000(shell),1004(input),1007(log),1011(adb),1015(sdcard_rw),1028(sdcard_r),3001(net_bt_admin),3002(net_bt),3003(inet),3006(net_bw_stats),3009(readproc),3011(uhid) context=u:r:shell:s0

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

It looks like this is not related to docker-worker or generic-worker? Perhaps in a relops component?

Comment 2

[Andrew Erickson [:aerickson]]

PR: https://github.com/bclary/mozilla-bitbar-docker/pull/33

Comment 3

[Andrew Erickson [:aerickson]]

The image incorporating the PR above is now live/set as default.

Comment 4

[Andrew Erickson [:aerickson]]

I've identified another spot where the exception isn't being caught. https://github.com/bclary/mozilla-bitbar-docker/pull/38

Comment 5

[Andrew Erickson [:aerickson]]

The image including https://github.com/bclary/mozilla-bitbar-docker/pull/38 is now live.