Closed Bug 1597388 Opened 11 months ago Closed 7 months ago

Teach about:profiling about talking to a remote debuggee

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

enhancement

Tracking

(firefox76 fixed)

RESOLVED FIXED
Firefox 76
Tracking Status
firefox76 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The about:profiling page should work with both the local browser, and with a remote debuggee. The current architecture already uses the ActorReadyGeckoProfiler, which matches the PerfFront interface. The work for this bug is to ensure that we can properly select a remote target and wire in the actor system into the page. Specifically, we should mirror the URL parameter mechanism that about:debugging already uses.

I should be able to give an overview of what needs to be done here (but feel free to start diving in, it's not rocket science, just a bit/lot messy :) )

Flags: needinfo?(jdescottes)
Attached image about:profiling inlined

I spent some time today looking through this, and right now I think I'm inclined to iframe in the about:profiling page directly into about:debugging. Right now there is a little "lightbox" design, with a smaller profiler UI. I'm inclined to put the devtools UI into that, and if the custom settings are clicked, then the "lightbox" will expand to most of the screen, and show the about:profiling page. This way, we don't have to maintain any complicated code around connecting to remote sources, the about:debugging can set all of that up for us. This means that I'll probably tackle this after I do the styling of the page.

Assignee: nobody → gtatum
Status: NEW → ASSIGNED
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19ad6553c0ef
Hook about:profiling up to remote debugging; r=julienw,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Flags: needinfo?(jdescottes)
You need to log in before you can comment on or make changes to this bug.