1597390 - Searchfox integration exposes code coverage links for pages without coverage and a confusing 400 error is displayed

Status: RESOLVED WORKSFORME

(Testing :: Code Coverage, defect, P3)

Description

[Andrew Sutherland [:asuth] (he/him)]

Right now the following test files show "Code Coverage" links in searchfox:

• https://searchfox.org/mozilla-central/source/dom/tests/mochitest/storageevent/test_storageSessionStorageEventCheckNoPropagation.html
• https://searchfox.org/mozilla-central/source/dom/tests/mochitest/storageevent/interOriginTest2.js

If I click on them, I get 400 errors "Failed to load coverage: 400 - BAD REQUEST" which is confusing.

• https://coverage.moz.tools/#revision=latest&path=dom/tests/mochitest/storageevent/test_storageSessionStorageEventCheckNoPropagation.html&view=file
• https://coverage.moz.tools/#revision=latest&path=dom/tests/mochitest/storageevent/interOriginTest2.js&view=file

It appears that dom/test/ isn't indexed at all per https://coverage.moz.tools/#revision=latest&path=dom&view=directory ?

It's possible the files in question are disabled, and while it would be best if the coverage tool knew that, just having an error better than 400 would be helpful I think. (Or maybe this is a legit error that should be fixed, in which case, that would also be good! :)

Comment 1

[Marco Castelluccio [:marco]]

We intentionally don't have coverage for test files. While that might change in the future, I think for now the best solution would be:

1. Us showing a nicer error message;
2. If possible, Searchfox not adding a "Code Coverage" link on test files.

Comment 2

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:ekyle, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

We intentionally don't have coverage for test files.

This problem is general for all files that don't end up being compiled.

Comment 5

[Nicolas Guichard]

Searchfox doesn't link to coverage.moz.tools at all since https://github.com/mozsearch/mozsearch/commit/962360f92c4fc559ed1dffc174e317b63097faea.