1597401 - Comment in StaticPrefList.yaml about media prefs getters is no longer relevant

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The comment here is no longer relevant because as of bug 1564724 we programatically generate our getters so that they're always snake case. This means that this comment can be removed.

I want to hold onto to this bug as a good first bug for some upcoming onboarding, so please do not work on it without speaking to me first.

Comment 1

[Elliot Matthew]

Hi, Getting familiar with the phabricator process, looking for a first simple bug. Id like to take this bug on.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Elliot Matthew from comment #1)

Hi, Getting familiar with the phabricator process, looking for a first simple bug. Id like to take this bug on.

Sure, I'll look for another bug that can be used for onboarding. Assigning to you; let me know if you need help with working on the bug.

Comment 3

[Elliot Matthew]

Awesome thanks just removed the comment on my local machine. found the comment on a different line 5424. Ive pulled the latest updates from the source code, using. hg pull -u. Just checking this is Ok?

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Do you have the fxtree/firefoxtree mercurial extension installed? You'll typically want to make changes upon the central tag that fxtree exposes. This tag tracks the current head of the mozilla-central repository at the time of pulling.

In my experience hg pull -u does not update you to the central tag (even if you pulled while on a central tag). I would suggest you instead use hg up -r central after each pull to make sure you're on central.

Comment 5

[Elliot Matthew]

Attachment: Bug 1597401 - Removes comment about media static prefs that is no longer relevant. r=bryce

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hawkin55, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Paul Adenot (:padenot)]

I'm landing this, patch looks good.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c860c6112d8
Removes comment about media static prefs that is no longer relevant. r=bryce

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9c860c6112d8