Open Bug 1597409 Opened 5 years ago Updated 2 years ago

Fix uses of mozilla::dom::Document::GetXULWindowIfTopLevelChrome in dom/base/Document.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Project Flags:
Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

In file dom/base/Document.cpp

Just retrieves the DocShell for a Document and checks it for null.

Change to just not use the nsIDocShellTreeItem type, and use the nsIDocShell type instead.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

Nika says GetXULWindowIfTopLevelChrome is only used in the parent process, so won't be broken by Fission. We don't need to remove it before Fission MVP.

Blocks: rmrf-docshell-tree-item
No longer blocks: rm-docshell-tree-item
Fission Milestone: M6 → Future
Severity: normal normal → S3 S3
You need to log in before you can comment on or make changes to this bug.