1597426 - Fix uses of nsFrameLoader::StartDestroy in dom/base/nsFrameLoader.cpp

Status: RESOLVED DUPLICATE of bug 1597512

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file dom/base/nsFrameLoader.cpp

Uses DocShell tree to get parent item, gets owner of parent item, and removes tree-item from it.

This will change to some sort of de-registration from the BrowsingContextGroup, or get removed and the de-registration done elsewhere.

TabContext may need to acquire a “mPrimaryContentShell” to mirror nsDocShellTreeOwner’s field.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I don't quite understand what's needed here. There's only one use of StartDestroy and it's in Destroy, so I assume that I'm misunderstanding what this bug is about.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

In the absence of info, dropping bug.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

This field is related to the mPrimaryContentShell field, which may be possible to remove. Marking as a duplicate of bug 1597512