Closed Bug 1597433 Opened 2 months ago Closed 1 month ago

Fix uses of nsGlobalWindowInner::CallOnChildren in dom/base/nsGlobalWindowInner.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M6
Tracking Status
firefox73 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:rename])

Attachments

(2 files)

In file dom/base/nsGlobalWindowInner.cpp

Iterates over all children in docshell tree.

Rename to CallOnInProcessChildren.

Change to using BrowsingContext.

Caller code needs to be fixed.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b874f97516f5
part 1: Fix uses of nsIDocShellTreeItem in nsGlobalWindowInner::CallOnChildren. r=kmag
https://hg.mozilla.org/integration/autoland/rev/a35c4e0fca3f
part 2: Rename nsGlobalWindowInner::CallOnChildren -> nsGlobalWindowInner::CallOnInProcessChildren. r=kmag
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Regressions: 1605674
You need to log in before you can comment on or make changes to this bug.