Fix uses of UpdateDocShellOrientationLock in dom/base/nsScreen.cpp
Categories
(Core :: DOM: Navigation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: djvj, Assigned: smacleod)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:hard])
In file dom/base/nsScreen.cpp
Uses DocShellTree to get same-type root of DocShell associated with incoming window.
- Calls “SetOrientationLock” on the root docshell.
Called from Screen::mozLockOrientation web API
Root can be out-of-process.
Low-frequency event that is coarse grained and not that performance sensitive.
Convert to BrowsingContext to traverse ancestors.
- If tree goes out of process, use IPC to forward SetOrientationLock to correct process.
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
|
||
Updated•5 years ago
|
|
||
Comment 2•4 years ago
|
||
It appears as though OrientationLock is android only right now, so this may not be super high priority for the initial work, but this likely could be somewhat easily handled with an OrientationLock synced field on the root BrowsingContext.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
Fixing this as part of https://phabricator.services.mozilla.com/D70416
|
|
Assignee | |
Comment 4•4 years ago
|
||
Fixed by https://hg.mozilla.org/mozilla-central/rev/e110f422c3e0 as part of Bug 1597413
Description
•