Open Bug 1597446 Opened 2 months ago Updated 2 months ago

Fix uses of mozilla::dom::PluginDocument::StartDocumentLoad in dom/html/PluginDocument.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

Fission Milestone M6

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

In file dom/html/PluginDocument.cpp

QueryInterfaces a DocShell out of a bare nsISupports argment (aContainer).

Compares the name of that using NameEquals.

NameEquals is already implemented in terms of BrowsingContext.

Should be replaceable with a dynamic check for DocShell, and directly getting the BrowsingContext off of that to check name.

Only other implementor of nsIDocShellTreeItem (aside from nsDocShell) is nsWebBrowser, which does not carry a BrowsingContext.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.