Closed Bug 1597446 Opened 5 years ago Closed 5 years ago

Audit nsIDocShellTreeItem usage in mozilla::dom::PluginDocument::StartDocumentLoad in dom/html/PluginDocument.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Project Flags:
Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

In file dom/html/PluginDocument.cpp

QueryInterfaces a DocShell out of a bare nsISupports argment (aContainer).

Compares the name of that using NameEquals.

NameEquals is already implemented in terms of BrowsingContext.

Should be replaceable with a dynamic check for DocShell, and directly getting the BrowsingContext off of that to check name.

Only other implementor of nsIDocShellTreeItem (aside from nsDocShell) is nsWebBrowser, which does not carry a BrowsingContext.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
Summary: Fix uses of mozilla::dom::PluginDocument::StartDocumentLoad in dom/html/PluginDocument.cpp → Audit nsIDocShellTreeItem usage in mozilla::dom::PluginDocument::StartDocumentLoad in dom/html/PluginDocument.cpp

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Fission Milestone: M6 → M6b

This is plugin-related so WONTFIX for Fission.

Status: NEW → RESOLVED
Fission Milestone: M6b → Future
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.