Closed Bug 1597448 Opened 1 year ago Closed 10 months ago

Fix uses of mozilla::dom::BrowserChild::ApplyShowInfo in dom/ipc/BrowserChild.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla74
Fission Milestone M6
Tracking Status
firefox74 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

In file dom/ipc/BrowserChild.cpp

https://searchfox.org/mozilla-central/rev/2a10f4812f3f7c7645d253a4fe52f26bf58e20e8/dom/ipc/BrowserChild.cpp#1155

Only usage is a SetName on the given DocShell if IsMozBrowser is set.

Inner comment shows that this code is strictly B2G related.

Use can be removed, entirely.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Attachment #9123777 - Attachment description: Bug 1597448 - Remove B2G legacy code path from mozilla::dom::BrowserChild::ApplyParentShowInfo(). → Bug 1597448 - Fix uses nsIDocShellTreeItem of mozilla::dom::BrowserChild::ApplyParentShowInfo().
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6fcec6a58c9
Fix uses nsIDocShellTreeItem of mozilla::dom::BrowserChild::ApplyParentShowInfo(). r=kmag
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.