Closed Bug 1597455 Opened 11 months ago Closed 7 months ago

Fix uses of nsMixedContentEvent::Run in dom/security/nsMixedContentBlocker.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Fission Milestone M6
Tracking Status
firefox77 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

In file dom/security/nsMixedContentBlocker.cpp

Ensure that this event is dispatched on the same process that contains the DocShell it runs on.

Otherwise, change uses of DocShell tree to use BrowsingContext instad.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED

kmag, Tetsuharu's nsMixedContentEvent::Run() patch is still waiting for your review. Would you like to load balance this review to someone else?

Tetsuharu, does this bug break the MixedContentBlocker's blocking functionality or just its UI? ckershb says MixedContentBlocker support for Fission should block M5 Dogfooding.

Fission Milestone: M6 → M5
Flags: needinfo?(tetsuharu.ohzeki)
Flags: needinfo?(kmaglione+bmo)

Correction: ckerschb says mixed content blocking doesn't need to block M5 Dogfooding if we warn potential users before they start testing. Moving this bug back to the M6 Nightly milestone.

Fission Milestone: M5 → M6
Flags: needinfo?(kmaglione+bmo)
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/73cc073f9dc7
Fix uses nsIDocShellTreeItem of nsMixedContentEvent::Run(). r=kmag,baku
Flags: needinfo?(tetsuharu.ohzeki)
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.