1597482 - Fix uses of GetProfileTimelineSubDocShells in layout/base/nsRefreshDriver.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file layout/base/nsRefreshDriver.cpp

Uses DocShellEnumerator

Called only by RefreshDriver::Tick - performance sensitive

• No IPC!

Related to profiling code - returns all descendant docshells that are visible and recording profile markers.

Calls “AddMarkerForDocShell” on all enumerated docshells, adding “Paint” marker.

Possible fix:

• Change to use BrowsingContext tree
• For in-process nodes, call “AddMarkerForDocShell” as now.
• For out-of-process child nodes, accumulate them in a vector.
• Issue single IPC call to chrome to dispatch marker additions to children.
• This is a complicated fix that GFX and Devtools team will have to figure out.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Steven MacLeod [:smacleod]]

Attachment: Bug 1597482 - Replace nsIDocShellTreeItem with BrowsingContext in GetProfileTimelineSubDocShells. r=smaug

GetProfileTimelineSubDocShells was using nsiDocShellTreeItem to walk the
DocShells that are visible and recording profile markers. This change switches
to using BrowsingContext for the walk, and ignores OOP iframes as they aren't
painting in the current process.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cee80d6cbacb
Replace nsIDocShellTreeItem with BrowsingContext in GetProfileTimelineSubDocShells. r=mstange

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/cee80d6cbacb