Open Bug 1597490 Opened 2 months ago Updated 28 days ago

Fix uses of nsXULPopupManager::IsChildOfDocShell, HidePopupsInDocShell in layout/xul/nsXULPopupManager.cpp


(Core :: DOM: Navigation, defect, P3)




Fission Milestone M6


(Reporter: djvj, Unassigned)


(Blocks 1 open bug)


(Whiteboard: [rm-docshell-tree-item:simple])

In file layout/xul/nsXULPopupManager.cpp

HidePopupsInDocShell is only user of IsChildOfDocShell, and its only use of nsIDocShellTreeItem is to accept a pointer to one as an argument and pass it to IsChildOfDocShell.

Checks if a Document is a child of a given nsIDocShellTreeItem.

Gets the Document’s DocShell, then walks up the DocShell tree, comparing against the given tree-item.

Can be converted entirely to BrowsingContext.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.