Closed Bug 1597493 Opened 2 months ago Closed Last month

Fix uses of mozilla::net::GetLoadContextInfo in netwerk/base/LoadContextInfo.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M6
Tracking Status
firefox73 --- fixed

People

(Reporter: djvj, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

In file netwerk/base/LoadContextInfo.cpp

QueryInterfaces an nsILoadContext to a DocShell (tree item), and checks its ItemType.

Change to pulling BrowsingContext out of DocShell to check against its ItemType.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

It is not quite clear to me if GetBrowsingContext can ever be null that is why I opened Bug 1604040.

Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/57ee8e8fa11b
Remove nsIDocShellTreeItem from GetLoadContextInfo. r=smaug
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.