Open Bug 1597507 Opened 1 year ago Updated 4 months ago

Audit nsIDocShellTreeItem usage in mozilla::AddonManagerWebAPI::IsAPIEnabled in toolkit/mozapps/extensions/AddonManagerWebAPI.cpp

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

ASSIGNED
Fission Milestone Future

People

(Reporter: djvj, Assigned: zombie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

In file toolkit/mozapps/extensions/AddonManagerWebAPI.cpp

There’s an explicit note about here about out-of-process issues not being in play:

Simple bug - just change it to using BrowsingContext tree to get in-process same-type parent.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

Moving to Add-ons Manager component.

Please audit this use of the nsIDocShellTreeItem interface. With Fission enabled, Documents and nsDocShells for related frames, such as subframes and parent documents, may not be available within the current process and the corresponding nsIDocShellTreeItem methods will return null

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

Fission documentation about replacing nsIDocShellTree Item:
https://wiki.mozilla.org/Project_Fission/DocShell_Tree_Replace

:farre's presentation with examples of replacing nsIDocShellTreeItem with BrowsingContext, WindowContext, SyncedContexts, and BrowsingContextGroup:
https://docs.google.com/presentation/d/1K4j6ngty64TZjJNS5qH-MBoOm3TI2dJedVsbH8jUhKE/edit#slide=id.g6e35225e5d_1_264

Component: DOM: Navigation → Add-ons Manager
Priority: P3 → --
Product: Core → Toolkit
Summary: Fix uses of mozilla::AddonManagerWebAPI::IsAPIEnabled in toolkit/mozapps/extensions/AddonManagerWebAPI.cpp → Audit nsIDocShellTreeItem usage in mozilla::AddonManagerWebAPI::IsAPIEnabled in toolkit/mozapps/extensions/AddonManagerWebAPI.cpp
Assignee: nobody → tomica
Priority: -- → P2

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Fission Milestone: M6 → M6c
Status: NEW → ASSIGNED
Fission Milestone: M6c → Future
You need to log in before you can comment on or make changes to this bug.