1597620 - update loop (patch apply failed)

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[vtol]

Attachment: patch apply failed

• W10 Pro x_64 v1909 b18363.476
• affected FX (x_64 en-GB) -> 71.0b10 | 72.0a1
• various FX profiles
• FX instances being launched with -n -P
• update setting:

• [x] Check for updates but let you choose to install them
• [x] Use a background service to install updates

---

in a search for duplicates came across

• bug 718443
• bug 1321822

but since both appear stale/unattended decided to lodge this one

---

Having applied an available update (patch) and restarted FX it keeps on promoting available updates in an endless loop.

Not sure whether pertinent but the the update logs are also exhibiting the failure of patches being applied.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Okay, let's try to get some more detail from the log file that's generated while applying the update; there should be some more specific error messages there. Please follow these steps:

1. Type about:config in the URL bar and press enter.
2. Click the "Accept the risk and continue" button if it is displayed.
3. Type devtools.chrome.enabled in the search box.
4. If the value you see is false and not true, toggle it to true by clicking the double-arrow button on the right.
5. From the application menu, open Web Developer -> Browser Console (or press Ctrl+Shift+J).
6. Copy and paste the following into the text box at the bottom:
   var fileLocator = Cc["@mozilla.org/file/directory_service;1"].getService(Ci.nsIProperties); var dir = fileLocator.get("UpdRootD", Ci.nsIFile); dir.reveal();. This should get you a File Explorer window.
7. From that window, open the updates subdirectory and attach the last-update.log and the backup-update.log files from there to this bug.

Thanks!

Comment 2

[vtol]

Attachment: last-update.log

Comment 3

[vtol]

Attachment: backup-update.log

Mind that in order to get around th issue a full installer been downloaded and applied

Comment 4

[vtol]

Attachment: patch apply failed recent beta.png

adding attachements pertaining to recent beta

Comment 5

[vtol]

Attachment: last-update.log

Comment 6

[vtol]

Attachment: backup-update.log

Comment 7

[vtol]

Attachment: ss with doorhanger.png

1. first the differential patch is downaloaded and installation fails
2. after restart next attempt then downloads the full patch and installation fails
3. after restart doorhanger is being displayed

---

last-update.log exhibiting

rename_file: failed to rename file - src: C:\Program Files\Mozilla\Firefox Nightly, dst:C:\Program Files\Mozilla\Firefox Nightly.bak, err: 13
Moving destDir to tmpDir failed, err: 7
failed: 7

Comment 8

[Molly Howell (she/her) (mostly inactive)]

Great, thank you.

I think this is likely to be related to bug 1596778; this looks like exactly the same symptoms and it started happening around the right time, and there's been several other reports of that same problem so it's probably pretty common. The good news is we have a fix for that bug, so what I'll ask you to do is see if this problem goes away once that fix reaches beta (which might be the next beta, or the one after that I'm not certain). If it's not better then, we'll see if something else is going on.

Thanks again.

Comment 9

[vtol]

Suppose the patch will hit Nightly first since it is affected too? If so I can report back on Nighly once the patch is released

Comment 10

[Molly Howell (she/her) (mostly inactive)]

That's right, yes; if you don't mind trying that, it would be helpful.

Comment 11

[vtol]

Sure, once the patch hits the Nightly code base

Comment 12

[vtol]

For the last 2 days the issue did not exhibit and thus presumably the relevant patchset sorted it.

That said a fresh installer that containes the patchset had to be downloaded or else the update loop could not be escaped - which is logical. Suppose that will be required for the beta branch as well, once the the code the gets uplifted.

Will you ask for an uplift to the current beta 71 branch or let it ride the trains?

Comment 13

[Robert Strong (they/them - no direct email)]

A different fix landed on Beta and this patch will ride the trains.