Remote Settings worker should use error handling to catch errors thrown in the worker script, and report via telemetry
Categories
(Firefox :: Remote Settings Client, defect, P3)
Tracking
()
People
(Reporter: Gijs, Assigned: leplatrem)
References
Details
Attachments
(1 file)
From Andrew's review feedback in bug 1594521:
You might want to consider adding an "error" event handler here now or in the future. If an unhandled error (note: not an unhandled rejection) happens in a Worker, this will generate an error that bubbles to the WorkerGlobalScope and then if it's not handled there will bubble/propagate back to the (Chrome)Worker here. See https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2 on that.
It might be appropriate in such a case to consider rejecting all outstanding promises, stopping the worker, and handling shutdown logic. The general idea would be:
- Make tests fail if you ever emit any error during processing.
- Help avoid pathological situations where errors hang browser shutdown.
Ideally this would also be coupled to telemetry so you can see that this is happening and act on problems proactively.
|
||
Comment 1•4 years ago
|
||
The priority flag is not set for this bug.
:leplatrem, could you have a look please?
For more information, please visit auto_nag documentation.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by mleplatre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/628b5082eae3 Catch Remote Settings worker crashes r=Gijs
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•