Closed Bug 1597689 Opened 3 months ago Closed 3 months ago

Update Picture-in-Picture image assets

Categories

(Toolkit :: Video/Audio Controls, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(3 files)

emanuela sent me some updated image assets for Picture-in-Picture. I'll attach them to this bug.

Attached image pip.svg
Attached image reverse-pip.svg
Assignee: nobody → mconley
Priority: -- → P1

I had to update the pip.svg file to use context-fill so that we can dynamically update the path colour, but these are otherwise untouched.

Oh, and just updated to get rid of a fill-opacity rule on the pip.svg file too.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66d38b28491e
Update Picture-in-Picture image assets. r=mstriemer
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Comment on attachment 9109987 [details]
Bug 1597689 - Update Picture-in-Picture image assets. r?mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: Picture-in-Picture will use out-of-date image assets that will not match Firefox 72's.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just swapping in some image assets.
  • String changes made/needed:
Attachment #9109987 - Flags: approval-mozilla-beta?

Comment on attachment 9109987 [details]
Bug 1597689 - Update Picture-in-Picture image assets. r?mstriemer

Low risk, visual fix for a new feature, uplift approved for the beta branch before RC.

Attachment #9109987 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Depends on: 1598886
You need to log in before you can comment on or make changes to this bug.