Closed Bug 1597708 Opened 5 years ago Closed 5 years ago

Deploy What's New Badge for 72

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Control when users see the notification in the toolbar.
This does not affect the Applications Menu entry point (always present).
QA Steps: https://docs.google.com/document/d/1iuq-U2IilKUgN9hsPQHjkSFhjj_dQvdfjowhv-3fHT0/edit#

Priority: -- → P1

For new profiles (<= 28 days) the Firefox accounts badge should show first and then the What's New button badge.

We want to encode this requirement in the What's New badge: allow new profiles to get the local FxA badge but after the initial 28 days this badge would take precedence.

Depends on: 1599113
Depends on: 1599116
Depends on: 1599711

A local copy of messages are now in Nightly 72 we need to copy them over to RS with the correct targeting.
https://hg.mozilla.org/mozilla-central/rev/c04064a9a62a

Assignee: nobody → andrei.br92

Deploy What's New Badge for 72
Firefox Beta 72

We have tested the Deploy What's New Badge for 72 feature.

QA’s recommendation: GREEN - SHIP IT

Reasoning:

  • We haven’t found any issues during testing.

Testing Summary:

  • Verified that the “Watch videos while you browse”, “Fewer annoying site pop-ups”, and “Fingerprinters” messages are correctly displayed in the “What’s New” panel.
  • Verified that each message redirects to the URL specified in the “Content QA Steps” document.
  • Verified that the counter is displayed in the “Fingerprinters” message after at least 10 fingerprinters were blocked.
  • Verified that the messages are successfully displayed in the “Private Window” mode.
  • Verified that the messages are not displayed on Firefox 70.
  • Verified that the messages are successfully displayed after browser update.
  • Verified that the messages are respecting the browser’s “Light” and “Dark” themes colors.
  • Verified that the afferent telemetry pings are displayed in the “Browser Console”.
  • Verified that the telemetry pings are successfully sent to a local server.

Tested Platforms:

  • Windows 10 x64
  • Mac OS 10.15
  • Ubuntu 18.04 x64

Tested Firefox versions:

  • Firefox Beta 72.0b5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
// Has to be for 72 only AND
firefoxVersion == 72 &&
// (user has clicked the FxA button OR their profile is older than 28 days) AND
(hasAccessedFxAPanel || currentDate|date - 2419200000 >= profileAgeCreated) &&
( // This part is meant to limit the badge to the first 4 days
  !messageImpressions['WHATS_NEW_BADGE_72'] || // They never saw the badge
  (messageImpressions['WHATS_NEW_BADGE_72']|length >= 1 && // Or they saw it AND
     // That first impression happened in the past 4 days
    currentDate|date - messageImpressions['WHATS_NEW_BADGE_72'][0] <= 345600000))

Toolbar Badge targeting expression.

This content is going out to 72 release today through Remote Settings. We've tested them in the staging environment (comment #4).

Flags: needinfo?(pascalc)

Forwarding the NI to the 72 relman owner

Flags: needinfo?(pascalc) → needinfo?(jcristau)

Thanks for the heads-up Andrei.

Flags: needinfo?(jcristau)
You need to log in before you can comment on or make changes to this bug.