Some colors in classic theme are weird

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: Sergei Dolgov, Assigned: Sergei Dolgov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

16 years ago
eColor_highlight looks weird, also menu color may correspond to system-wide, as
Classic Theme should match platform as possible.
(Assignee)

Comment 1

16 years ago
Created attachment 93049 [details] [diff] [review]
Patch

Little patch, adding more native look to Classic Theme

Comment 2

16 years ago
Comment on attachment 93049 [details] [diff] [review]
Patch

if kail likes it, r=timeless
as always, i don't like the tabs.
Attachment #93049 - Flags: review+
(Assignee)

Comment 3

16 years ago
Created attachment 95945 [details] [diff] [review]
Patch.More colors

Added some system-dependant colors.
Other colors are corrected according to Mac code.
Cases are reordered to match order in declaration files (for coder convinience)

Some other aMetric parameters changed - WindowTitleHeight, SubmenuDelay (it was
very hard to reach sometimes submenus in bookmarks), carent blink time slightly
decreased.
Attachment #93049 - Attachment is obsolete: true
(Assignee)

Comment 4

16 years ago
Despite there are more system-wide colors defined in Dan0 (BeOS 5.1), i didn't
bother to put it here (as no defines for Dan0 now in Mozilla)
(Assignee)

Comment 5

16 years ago
Created attachment 96025 [details] [diff] [review]
Patch.Style

Idents (tabs), spaces, number representation
Attachment #95945 - Attachment is obsolete: true

Comment 6

16 years ago
qa -> pmac@netscape.com
QA Contact: paw → pmac
(Assignee)

Comment 7

16 years ago
Links to help BeOS-less people to estimate changes:
Menus following system menu colors (look at menu bar color in IRC-client in
left-top for comparison), Selected text and and selected text background in
Navigator, Menu and Preference header highlight.  - all following BeOS system
settings:
http://www.beos.ru/files/BeZilla_TextSelectio_SystemMenuColor_HighlightInMenu.jpg
Overall look of widgets in Navigator and Chat:
http://www.beos.ru/files/BeZilla_Navigator_Chat.jpg
Active and inactive buttons in Find Dialog. Inactive selected text in browser
window:
http://www.beos.ru/files/Bezilla_Active_and_Inactive_buttons_Inactive text.jpg

Comment 8

16 years ago
Comment on attachment 96025 [details] [diff] [review]
Patch.Style

i'm removing two tabs and changing one comment line
r=timeless
sr=blizzard (ports)
Attachment #96025 - Flags: superreview+
Attachment #96025 - Flags: review+

Comment 9

16 years ago
this was checked in, marking fixed
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.