159771 - Some colors in classic theme are weird

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Sergei Dolgov]

eColor_highlight looks weird, also menu color may correspond to system-wide, as
Classic Theme should match platform as possible.

Comment 1

[Sergei Dolgov]

Attachment: Patch

Little patch, adding more native look to Classic Theme

Comment 2

[timeless]

Comment on attachment 93049 [details] [diff] [review]
Patch

if kail likes it, r=timeless
as always, i don't like the tabs.

Comment 3

[Sergei Dolgov]

Attachment: Patch.More colors

Added some system-dependant colors.
Other colors are corrected according to Mac code.
Cases are reordered to match order in declaration files (for coder convinience)

Some other aMetric parameters changed - WindowTitleHeight, SubmenuDelay (it was
very hard to reach sometimes submenus in bookmarks), carent blink time slightly
decreased.

Comment 4

[Sergei Dolgov]

Despite there are more system-wide colors defined in Dan0 (BeOS 5.1), i didn't
bother to put it here (as no defines for Dan0 now in Mozilla)

Comment 5

[Sergei Dolgov]

Attachment: Patch.Style

Idents (tabs), spaces, number representation

Comment 6

[Paul Wyskoczka]

qa -> [e-mail]

Comment 7

[Sergei Dolgov]

Links to help BeOS-less people to estimate changes:
Menus following system menu colors (look at menu bar color in IRC-client in
left-top for comparison), Selected text and and selected text background in
Navigator, Menu and Preference header highlight.  - all following BeOS system
settings:
http://www.beos.ru/files/BeZilla_TextSelectio_SystemMenuColor_HighlightInMenu.jpg
Overall look of widgets in Navigator and Chat:
http://www.beos.ru/files/BeZilla_Navigator_Chat.jpg
Active and inactive buttons in Find Dialog. Inactive selected text in browser
window:
http://www.beos.ru/files/Bezilla_Active_and_Inactive_buttons_Inactive text.jpg

Comment 8

[timeless]

Comment on attachment 96025 [details] [diff] [review]
Patch.Style

i'm removing two tabs and changing one comment line
r=timeless
sr=blizzard (ports)

Comment 9

[Paul]

this was checked in, marking fixed