mailto form should accept more than just text/plain encoding

VERIFIED FIXED

Status

()

P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: mozilla, Assigned: alexsavulov)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed_on_trunk)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

17 years ago
The fix for bug 61893 requires that the enctype text/plain be used in order for
the form to be passed to the mail client. We should support others (at least
url-encoded -- the default) ala NS4.x

Apparently IE requires text/plain and most tutorials recommend it (because it is
human readable) but there may be some people using NS4 who don't want to have to
rewrite their pages. (think internal IS departments and intranets)

Looking at the code it should be a relativly simple fix to just add url-encoded
encoding to the list we check for, but there may be issues with keeping the path
open for other encodings down the line.

Note also that there is a request to attach files at some point through "file"
input elements which would entail the acceptance of multipart-form-encoded
That is bug 135980

Updated

17 years ago
Priority: -- → P3
(Assignee)

Comment 1

17 years ago
Created attachment 93371 [details] [diff] [review]
fix for the bug (actually enhancement)

the patch adds the desired functionality and moves some code to a local
function to avoid code duplication.
Comment on attachment 93371 [details] [diff] [review]
fix for the bug (actually enhancement)

1. Make HandleSubject static to avoid polluting the linker namespace, and
change the name to something like CreateMailtoSubject or HandleMailtoSubject.

2. hasSubject, hasParams, paramSep no longer need to be declared down where you
removed the stuff you put into HandleSubject.
(Assignee)

Comment 3

17 years ago
Created attachment 93375 [details] [diff] [review]
improved fix

added jkeiser's requirements
Attachment #93371 - Attachment is obsolete: true
Comment on attachment 93375 [details] [diff] [review]
improved fix

r=jkeiser
Attachment #93375 - Flags: review+
Comment on attachment 93375 [details] [diff] [review]
improved fix

> +HandleMailtoSubject(nsCAutoString& aPath) {

Make that take a nsCString& (which is not as specific) and sr=bzbarsky
Attachment #93375 - Flags: superreview+
(Assignee)

Comment 6

17 years ago
Created attachment 93605 [details] [diff] [review]
replaced autostring with string

improved patch
(Assignee)

Updated

17 years ago
Attachment #93375 - Attachment is obsolete: true
(Assignee)

Comment 7

17 years ago
Comment on attachment 93605 [details] [diff] [review]
replaced autostring with string

trnsferring review flags
Attachment #93605 - Flags: superreview+
Attachment #93605 - Flags: review+

Comment 8

17 years ago
Comment on attachment 93605 [details] [diff] [review]
replaced autostring with string

a=asa (on behalf of drivers) for checkin to 1.1
Attachment #93605 - Flags: approval+
(Assignee)

Comment 9

17 years ago
fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: fixed on trunk
(Assignee)

Updated

17 years ago
Whiteboard: fixed on trunk → fixed_on_trunk

Comment 10

17 years ago
verifying build 2002-08-05-08-trunk
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.