Closed Bug 1597888 Opened 2 years ago Closed 2 years ago

Default topsites tailored for "CN" region

Categories

(Firefox :: New Tab Page, enhancement)

enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox75 --- verified

People

(Reporter: hectorz, Assigned: hectorz)

Details

Attachments

(2 files)

Beijing office distributes China repacks of desktop Fx, with customized homepage and newtab page. We're however using the vanilla firstrun page, either hosted at mozilla.org or the current about:welcome, mostly because w/o active maintenance our own firstrun page is either outdated or not really helpful with only generic messages.

In the current about:welcome, there's not a tailored list of default topsites defined for "CN" region 1, and the fallback list doesn't fit well with the local situation. We have to override it in our distribution, with pref "browser.newtabpage.pinned" set to a list of alternative sites.

We'd like to request the upstream inclusion of a list tailored for "CN" region. Our suggestion for the list: (and the icons we're using)

https://www.baidu.com/ (part of tippytop)
https://www.zhihu.com/ 2
https://www.ifeng.com/ 3
https://weibo.com/ 4
https://www.ctrip.com/ 5
https://www.iqiyi.com/ 6

I also found this spreadsheet 7, but I'm not sure whether the effort to create similar lists for tier 3 markets is still ongoing.

Thanks!

Component: Messaging System → New Tab Page

Tim, do you have guidance on next steps here?

Flags: needinfo?(tspurway)

Sure! :hectorz, can you write the patch to add these sites to https://searchfox.org/mozilla-central/rev/652014ca1183/browser/components/newtab/lib/ActivityStream.jsm#95-129 and attach it to this bug?

:nanj can review and land it.

Flags: needinfo?(tspurway) → needinfo?(najiang)

(In reply to Tim Spurway [:tspurway] from comment #2)

Sure! :hectorz, can you write the patch to add these sites to https://searchfox.org/mozilla-central/rev/652014ca1183/browser/components/newtab/lib/ActivityStream.jsm#95-129 and attach it to this bug?

:nanj can review and land it.

Thanks, Tim!

I'll send the patch sometime next week, since we're temporarily working from home this week due to the 2019-nCoV outbreak, and I don't have m-c clone in my home laptop.

Assignee: nobody → bzhao
Status: NEW → ASSIGNED
Flags: needinfo?(najiang)
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d38cce801fec
Default topsites tailored for CN region. r=nanj

Ah, looks like the new images are somehow landed as empty files, I’ll figure this out tomorrow.

Attachment #9127041 - Attachment description: Bug 1597888 - Default topsites tailored for CN region. r?nanj → Bug 1597888 - Default topsites tailored for CN region. r=nanj
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79807dc95f05
Default topsites tailored for CN region. r=nanj

(In reply to Arthur Iakab [arthur_iakab] from comment #8)

Backed out changeset d38cce801fec (bug 1597888) for causing multiple build bustages.

......

Hector can you please take a look?

It's similar to bug 1486026, but in phabsend hg extension.

I've updated my phabsend to phabsend-moz and re-sent my patch.

Flags: needinfo?(bzhao)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

I have verified that the "baidu", "zhihu", "ifeng", "weibo", "ctrip" and "iqiyi" cards are displayed in the "Top Sites" area if the browser.search.region pref is set to CN. Verified using the latest Firefox Nightly (75.0a1 Build ID - 20200220093508) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.